Go Client command doesn't work

tldr-pages / tldr-pages.github.io

🌐 The website for the tldr pages project

http://tldr.sh/

MIT License

76 stars 36 forks source link

Go Client command doesn't work #52

Closed 20manas closed 3 years ago

20manas commented 3 years ago

The command provided is go get -u github.com/isacikgoz/tldr, but it does not seem to be working. But the command provided in the client repo (https://github.com/isacikgoz/tldr) is working: go get github.com/isacikgoz/tldr/cmd/tldr

agnivade commented 3 years ago

Woops that is correct.

@sbrl / @waldyrious - What was the latest decision around consolidating the list of clients from the 3 places (here, main repo, and the wiki)? I see some discussion around here https://github.com/tldr-pages/tldr-pages.github.io/pull/30 but the work of pointing to the wiki does not seem to be done yet.

sbrl commented 3 years ago

I can't remember, @agnivade. @waldyrious?

agnivade commented 3 years ago

I think the decision was to remove the list from the website entirely, and point to the wiki. And then finally, just have the main repo as the single source of truth.

waldyrious commented 3 years ago

Yeah, that was my plan, but I never got around to do it. 😓

Specifically:

[x] Removing the list of clients from the website, and leaving only a link to the wiki page, ensuring that any missing content from the wiki page is added there first;
[ ] Restructuring the list of clients in the README to match the contents and structure of the list on the wiki page (in particular, split by platform/usage mode, not by language);
[ ] Deleting the wiki list in favor of the README list. (Or perhaps converting it in an archive of old / outdated / abandoned clients?)

@20manas would you be willing to help with these steps?

20manas commented 3 years ago

Yes, sure, I'll do it. I suppose I should start by first making sure that all the clients on tldr-pages.github.io are on the wiki.

20manas commented 3 years ago

Okay, except for https://github.com/avih/tldr-fmt, all clients from tldr-pages.github.io are present in the wiki.

waldyrious commented 3 years ago

Thanks @20manas! By the way, I just fixed the installation instructions for isacikgoz/tldr on the wiki page as described in this issue's opening comment. I wonder if similar changes would be needed for the other Go clients listed there... 🤔

20manas commented 3 years ago

I've added the client on https://github.com/avih/tldr-fmt. I've also updated the C client's repo and url.

I think this change was specific to the isacikgoz/tldr project, so it won't be needed in other clients.

waldyrious commented 3 years ago

It looks like the only content still missing from the wiki page is yay -S tealdeer as an installation method for tealdeer. Can you please double-check to confirm I didn't miss anything else? After that we can move to a PR removing the list from the website :)

20manas commented 3 years ago

There is one minor discrepancy in the "Dash for MacOS" section which says Download instead of Downloads. I'm not sure which of them is correct. Apart from this (and yay -S tealdeer), everything else is the same in the wiki.

waldyrious commented 3 years ago

There is one minor discrepancy in the "Dash for MacOS" section which says Download instead of Downloads. I'm not sure which of them is correct.

Good catch! According to the user guide and the screenshots here and here, the correct spelling is in the plural, Downloads, so I fixed that on the wiki page.

waldyrious commented 3 years ago

This issue is now resolved after the merge of #53! 🎉

I'll close this and open a new one in the main repo to track merging of the wiki list of clients with the one in the README. Thanks @20manas!

waldyrious commented 3 years ago

I'll close this and open a new one in the main repo to track merging of the wiki list of clients with the one in the README.

Shame on me, I never got around to do that. Here it is, at last: https://github.com/tldr-pages/tldr/issues/5512