Custom default language specified by TLDR_LANGUAGE

tldr-pages / tldr-python-client

Python command-line client for tldr pages

https://pypi.org/project/tldr/

MIT License

596 stars 93 forks source link

Custom default language specified by TLDR_LANGUAGE #157

Closed nebnola closed 3 years ago

nebnola commented 3 years ago

Implements the suggestion from issue #156.

I hope I understood your comments correctly. In addition to using TLDR_LANGUAGE, I also fixed what I think is an error: https://github.com/tldr-pages/tldr-python-client/blob/f24f81fb01d2b1bb69840bc6f98921fcbd700033/tldr.py#L195-L198 This meant that if default_lang was in languages, then languages would get set to [], ignoring both variables. If I misunderstood something and this was intended, then feel free of course to change that part back

nebnola commented 3 years ago

Do you guys understand where this error comes from? I don't see what it has to do with the changes, but are there any further changes I should make?

bl-ue commented 3 years ago

Well, Python 3.5 is EOL (End-of-Life), and I think we should remove support for it. You can open an additional PR to remove 3.5 from here, and after we merge that into main, you can rebase main into this PR and the CI should be all green.

bl-ue commented 3 years ago

@nebnola now that #158 is merged, you can rebase.

git remote add upstream https://github.com/tldr-pages/tldr-python-client.git
git fetch upstream main
git rebase upstream/main
git push