search

tldr-pages / tldr-python-client

:snake: Python command-line client for tldr pages 📚
https://pypi.org/project/tldr/
MIT License
599 stars 95 forks source link

Improve wording of missing page error message #163

Closed CleanMachine1 closed 3 years ago

CleanMachine1 commented 3 years ago

I am surprised that this issue has gone unnoticed, it must be because we have so pages documented ;)

Also I don't know whether you agree with the de-capitalization, however I feel this is correct since with using the word PRs, you are indicating that they are a part of an acronym

marchersimon commented 3 years ago

How about we use the same message as tldr-node-client:

If you want to contribute it, feel free to send a pull request to: https://www.github.com/tldr-pages/tldr.

CleanMachine1 commented 3 years ago

Sure, I don't see a problem with that.

CleanMachine1 commented 3 years ago

@MasterOdin I don't see the problem here. Is it setup to run with 3 lines instead of 4, or have I made a mistake?

CleanMachine1 commented 3 years ago

@MasterOdin You know the backend to this, I am sure you will look at this and find a fix within 20 seconds, because you know how this works.

Sorry for creating 9 waste commits, we'll squash when merging.

MasterOdin commented 3 years ago

@CleanMachine1 No problem! I made a commit that resolves the test failures. Don't worry about squashing on your end, I will handle doing that when I go to merge the PR.

CleanMachine1 commented 3 years ago

Ok, well, I'll leave this in your hands in terms of merging.

But I have 1 question, how long will this simple change take till this in the Arch Repos'

MasterOdin commented 3 years ago

But I have 1 question, how long will this simple change take till this in the Arch Repos'

I'm not sure as I have no hand in maintaining it. In the past it's been decently quick to update.

CleanMachine1 commented 3 years ago

Normally at a tag I think at least