search

tldr-pages / tldr-python-client

:snake: Python command-line client for tldr pages 📚
https://pypi.org/project/tldr/
MIT License
599 stars 95 forks source link

Change TLDR_CACHE_MAX_AGE default #170

Closed CleanMachine1 closed 2 years ago

CleanMachine1 commented 2 years ago

I feel 24 hours is extreme, and it annoys me when I first started using this client.

On average I probably only use tldr 1-2 times a day, therefore I have to wait each time for it to download a new cache everyday, which normally includes the additions of 0-10 pages/changes.

It goes from nearly instant with using an out of date cache to waiting a few seconds for a command if you use an updated cache which is just slightly annoying.

Simple change, however others may find this controversial :shrug:

edit: PS, I forgot to mention that I had already changed the cache date for my .zshrc a weeks back, however the change I made, I felt needed to be standardized

CleanMachine1 commented 2 years ago

Do I need to remove the comments?

sbrl commented 2 years ago

Hrm, some of the builds are failing here?

marchersimon commented 2 years ago

./tldr.py:33:67: E261 at least two spaces before inline comment ./tldr.py:34:63: E261 at least two spaces before inline comment ./tldr.py:35:63: E261 at least two spaces before inline comment ./tldr.py:35:89: E501 line too long (95 > 88 characters)

Those are all because of the comments. As already said, I don't think they're necessary.

CleanMachine1 commented 2 years ago

@MasterOdin Could we get a review?

CleanMachine1 commented 2 years ago

Can I get some reviews here please