tldr-pages / tldr-python-client

Python command-line client for tldr pages
https://pypi.org/project/tldr/
MIT License
596 stars 93 forks source link

README: remove ../local/.. from auto-completion setup command #181

Closed CleanMachine1 closed 2 years ago

CleanMachine1 commented 2 years ago

I am unsure whether this is correct however I am assuming that most machines have the ZSH share folder in /usr/share rather than /usr/local/share

MasterOdin commented 2 years ago

I'm not totally sure no that. macOS with homebrew installs all of zsh stuff into /usr/local/share, and nothing in /usr/share. I think historically that /usr/local is the right folder to install third-party stuff that is pertinent to just the local machine and should not be shared over the network.

I would be all for adding a note to say double check the folder location, and depending on your OS, you may need to use /usr/share, but I'd like to keep /usr/local/share as the default.

CleanMachine1 commented 2 years ago

From my knowledge of the Linux file system, /usr/bin and or /usr/share is for things installed with the system's package manager, whilst things like packages installed from the AUR for example go into a ./local version

Just a question, does Mac come with ZSH? Or is it a homebrew package

CleanMachine1 commented 2 years ago

adding a note seems sensible

MasterOdin commented 2 years ago

Mac does come with zsh by default. Unfortunately, there's not really any hard rules with file locations (like Homebrew was in /usr/local/ up until the latest version of macOS, and since then it's in /opt), so I don't think there's a "one size fits all" suggestion. It may be worthwhile to start a table to say on these OSes do X and on these other ones do Y and that might be better for everyone? We can update the table as we go along and have additional OSes get tested.

CleanMachine1 commented 2 years ago

That idea is good however I think using an entire table for something so simple will over-complicate things, and everyone installs things their own way, so it wouldn't probably be effective anyway