search

tldr-pages / tldr-python-client

Python command-line client for tldr pages
https://pypi.org/project/tldr/
MIT License
596 stars 93 forks source link

Feature/issue 188/enable multiple sources #192

Closed scottmuc closed 7 months ago

scottmuc commented 2 years ago

Hi @MasterOdin , @mrdavidlaing and I would like to submit this PR which relates to Issue #188 and potentially #147 and #146.

Hope you appreciate the additional tests!

If you like what you see, and would like more, we'll follow up with another PR. We have some ideas around some high-level functional testing of main but didn't want to add too much noise to this PR. We also believe we can use itertools.product to simplify the nesting of the loops.

We'll comment inline in this PR to some of the code snippets that might appear confusing at first glance.

scottmuc commented 2 years ago

Here's a demo if it in action: https://www.loom.com/share/08ed2a0053cd4c019412e33aa47e2bd8

scottmuc commented 2 years ago

@owenvoke would you be able to take a look at this?

Cheers

MasterOdin commented 2 years ago

Sorry for the delay on looking at this, will try to get to this sometime this week.

scottmuc commented 2 years ago

@MasterOdin nudge nudge 😄

scottmuc commented 7 months ago

Closing since I'm in favour of using https://github.com/charmbracelet/mods for unix program explanations. I'll work withing the constraints of local scripts/wikis/issue templates for sharing company specific stuff (which is what this PR was meant to enable).