search

tldr-pages / tldr-python-client

Python command-line client for tldr pages
https://pypi.org/project/tldr/
MIT License
596 stars 93 forks source link

ci: drop support for Python 3.6 #201

Closed owenvoke closed 1 year ago

owenvoke commented 1 year ago

I've also bumped actions/checkout and actions/setup-python to the latest versions. 👍🏻

I don't know enough about Python to know why the tests are failing, however. 👀

kbdharun commented 1 year ago

Seems like the build fails now too.

owenvoke commented 1 year ago

Looks like it's failing because the tests are expecting single quotes in output, whereas they are being given double quotes? 👀

kbdharun commented 1 year ago

Looks like it's failing because the tests are expecting single quotes in output, whereas they are being given double quotes? 👀

Oh 👀 , Edit: This makes sense see https://github.com/tldr-pages/tldr-python-client/pull/203

owenvoke commented 1 year ago

Actually, that might be irrelevant. 🤷🏻 I will see if I can bump pytest when I get home and see if that helps.

kbdharun commented 1 year ago

Nice, The CI passed 🥳

owenvoke commented 1 year ago

Looks like my changes have been applied separately, so closing this PR 👍🏻