tldr-pages / tldr-python-client

Python command-line client for tldr pages
https://pypi.org/project/tldr/
MIT License
592 stars 92 forks source link

Fix forcing color through termcolor #204

Closed MasterOdin closed 1 year ago

MasterOdin commented 1 year ago

This PR fixes a bug introduced by termcolor 2.1.0, where that library will now detect whether or not the process is running a TTY and disable outputting color if so. This broke using the --color argument to force color when piping to another process (e.g. less), as well as our pytest function for checking rendered output.

The fix is ensuring that we set the environment variable FORCE_COLOR in the cases where we want color, and might not have a TTY (e.g. in the pytest, or when using --color option).