search

tldr-pages / tldr-python-client

Python command-line client for tldr pages
https://pypi.org/project/tldr/
MIT License
592 stars 92 forks source link

`tldr --search "KEYWORDS"` does not work #231

Closed fazlearefin closed 2 months ago

fazlearefin commented 6 months ago

tldr --search seems to be not implemented

❯ tldr --version
tldr 3.2.0 (Client Specification 1.5)
❯ tldr --search memory
Please update cache
❯ tldr --search ls
Please update cache
❯
owenvoke commented 6 months ago

For some reason it's --update_cache (or -u). 🤔

https://github.com/tldr-pages/tldr-python-client/blob/6536569d4ab954dec33aa9166df940a918094c83/tldr.py#L431

I think we should alias this if possible, so it's --update (but support --update_cache for backwards compatibility).

fazlearefin commented 6 months ago

For some reason it's --update_cache (or -u). 🤔

https://github.com/tldr-pages/tldr-python-client/blob/6536569d4ab954dec33aa9166df940a918094c83/tldr.py#L431

I think we should alias this if possible, so it's --update (but support --update_cache for backwards compatibility).

Sorry for the confusion. I meant to say tldr --search does not work

kbdharun commented 6 months ago

Can confirm this issue, I was able to replicate it too.

owenvoke commented 6 months ago

Ah, my bad. 👍🏻 Well, I opened a PR to add the --update support anyway. 🤷🏻 https://github.com/tldr-pages/tldr-python-client/pull/232