search

tldr-pages / tldr-python-client

Python command-line client for tldr pages
https://pypi.org/project/tldr/
MIT License
592 stars 92 forks source link

feat : update platforms list and the --platform option #246

Closed patricedenis closed 1 month ago

patricedenis commented 1 month ago

This PR may close #234, #235 and #236. Be aware that this pull request is based only on code analysis and has not been tested! I would be really pleased if someone could test this PR and see if it works.

patricedenis commented 1 month ago

I'm sorry I didn't know how to continue the work that was done on #236 so I directly made a new PR.

patricedenis commented 1 month ago

It's nice to see that the workflow is checking my code so I can fix it. Good feature !

patricedenis commented 1 month ago

I don't understand the lint codebase message :

Run python3 -m flake8
./tldr.py:522:89: E501 line too long (106 > 88 characters)
./tldr.py:524:89: E501 line too long (116 > 88 characters)
Error: Process completed with exit code 1.

I opened the raw file in a text editor and did not see the supposed added characters on lines 522 and 524.

patricedenis commented 1 month ago

I don't understand the lint codebase message :

Run python3 -m flake8
./tldr.py:522:89: E501 line too long (106 > 88 characters)
./tldr.py:524:89: E501 line too long (116 > 88 characters)
Error: Process completed with exit code 1.

I opened the raw file in a text editor and did not see the supposed added characters on lines 522 and 524.

Ok I saw how to divide the 2 longer lines to ones that's fit with the 88 maximum length standard.

patricedenis commented 1 month ago

Now there's a e131 lint error. it's again related to indentation.