tldr-pages / tldr-python-client

Python command-line client for tldr pages
https://pypi.org/project/tldr/
MIT License
592 stars 92 forks source link

feat: add support for placeholder escaping, prep for release, misc #247

Closed kbdharun closed 1 month ago

kbdharun commented 1 month ago

Changes


I have been working on this since yesterday, and the changes are finally done. After this PR's merge, I will create a new release and once it is done will bump the Snapcraft files version.

This time the changelog is really big xD.


Related issues

Sample Screenshots

Placeholder escaping

image

image

image

For more details check out https://github.com/search?q=repo%3Atldr-pages%2Ftldr+%5C%7B%5C&type=code

New badge in README

image

patricedenis commented 1 month ago

It looks good ! All of those improvements, congrats @kbdharun and thanks ! I found a few minor addition that I could suggest, I will add them shortly.

kbdharun commented 1 month ago

I found a few minor addition that I could suggest, I will add them shortly.

If it's related to the PR feel free to suggest it here, if it's a new feature/minor update sure we can add it later.

patricedenis commented 1 month ago

Yeah thanks, I've just made a PR to this branch because I was not able to add it directly from the review process.

patricedenis commented 1 month ago

Ok @kbdharun : my PR on the brand does not seem to wook properly. The suggestion was to replace the line 60 on README.md from : [linux, osx, sunos, windows, common] to [android, linux, osx, sunos, windows, freebsd, netbsd, openbsd, common]

or better : android, freebsd, linux, netbsd, openbsd, osx, sunos, windows, common as you had written in the man doc.