search

tldr-pages / tldr-python-client

:snake: Python command-line client for tldr pages 📚
https://pypi.org/project/tldr/
MIT License
599 stars 95 forks source link

Cannot use most CLI options #62

Closed MasterOdin closed 6 years ago

MasterOdin commented 6 years ago

Cannot use most of the options (like os or source), due to: https://github.com/tldr-pages/tldr-python-client/blob/06ac37a7f0bbb207b179e16688229b89a2ee1435/tldr.py#L286-L295 line 295 overwrites the option array set on line 286 (which did contain os, source, etc.) and replaces it with the defaults for those options.

Test command:

./tldr -s sunos svcs
`svcs` documentation is not availableConsider contributing Pull Request to https://github.com/tldr-pages/tldr

The namespace before and after the pointed out line:

Before: Namespace(os=['sunos'], source='http://raw.github.com/tldr-pages/tldr/master/pages', update_cache=False)
After: Namespace(command=['svcs'], os=None, source='http://raw.github.com/tldr-pages/tldr/master/pages', update_cache=False)