tldr-pages / tldr-python-client

:snake: Python command-line client for tldr pages 📚
https://pypi.org/project/tldr/
MIT License
599 stars 95 forks source link

Add render flag to parse local markdown files #66

Closed MasterOdin closed 6 years ago

MasterOdin commented 6 years ago

Adds a render option (-r or --render) which assumes that all commands are then paths to local files and renders them for the user (for testing purposes).

felixonmars commented 6 years ago

The flag looks a bit ambiguous to me. I guess it would make more sense to specify a remote to override the default one? (And support something like file:///)

MasterOdin commented 6 years ago

This is the same flag as in both the tldr-node-client and tldr-cpp-client and so is consistent in that regard.

Additionally, it strikes me that --source file:///path/to/files seems more unintuitive as you're then special casing the file:/// source to not check for platform, go through cache, etc.

felixonmars commented 6 years ago

Indeed. Thanks for the patch!