search

tldr-pages / tldr-python-client

:snake: Python command-line client for tldr pages 📚
https://pypi.org/project/tldr/
MIT License
599 stars 95 forks source link

Check if environment variable colors are valid #71

Closed JacobCallahan closed 5 years ago

JacobCallahan commented 6 years ago

This implements a simple check to see if a user-supplied color is one that tldr can use. If not, then fall back to defaults. At this point, there is no warning, but one can be added later. Fixes #70

waldyrious commented 5 years ago

Thanks for the PR and sorry for the delayed response (I'm not a maintainer in this repo, but I try to help out with the tldr projects). I added a couple comments inline, but overall this looks good to be merged.

JacobCallahan commented 5 years ago

The python 3.4 branch failed in Travis during install. can someone restart that job?

waldyrious commented 5 years ago

@agnivade :point_up:

(by the way, following the discussion here, I think it would help if I was added as a collaborator in this repo, so I can assist with small stuff like this.)

agnivade commented 5 years ago

Done !

JacobCallahan commented 5 years ago

Any update on this, or should I close it?

agnivade commented 5 years ago

Woops, sorry for the delay. I am not the maintainer of the repo, but this seems simple enough. So merging it. Thanks @JacobCallahan !