search

tldr-pages / tldr-python-client

:snake: Python command-line client for tldr pages 📚
https://pypi.org/project/tldr/
MIT License
599 stars 95 forks source link

img #80

Closed VictoriaLa closed 4 years ago

JacobCallahan commented 5 years ago

The opening bracket renders in the preview. Screenshot from 2019-10-21 09-28-41

waldyrious commented 5 years ago

I'm not sure it's worth adding a generic logo to a specific client like this. If it were branded (e.g. to incorporate some reference to Python), then it might make sense; but as it is, IMO it risks confusing the client with the overall project, which is not the intent (this is just one of several clients for the tldr pages).

I'd suggest either reworking the image into a logo proposal specific to this client, or otherwise closing this issue and participating in the ongoing discussion at https://github.com/tldr-pages/tldr/issues/2986.

zlatanvasovic commented 4 years ago

I'm against this. We have the logo in the main repository, and it'd be really be needless to put it everywhere. Do others agree with closing the issue?

ping @waldyrious

waldyrious commented 4 years ago

As I mentioned above, I'm not opposed to having a specific logo/image for this client, but neither the image proposed in this PR nor the project-wide logo we implemented in tldr-pages/tldr#2986 would be suitable for that purpose.

Since we had no feedback from the opener of the PR after almost 3 months, I agree we can close the PR, with the understanding that it can be reopened if the author (or someone else) wishes to rework it based on the feedback above.