Set User-Agent header on urlopen requests

tldr-pages / tldr-python-client

:snake: Python command-line client for tldr pages 📚

https://pypi.org/project/tldr/

MIT License

599 stars 95 forks source link

Set User-Agent header on urlopen requests #89

Closed MasterOdin closed 4 years ago

MasterOdin commented 4 years ago

Fixes #81 Closes #82

Sets the User-Agent for urlopen requests. While technically unnecessary when pulling individual pages from GitHub, it's probably still useful to add this in case someone uses a default source that does require it. It is necessary for pulling the zip file as else a 403 forbidden error is returned by the page.

MasterOdin commented 4 years ago

Yes, it is still currently broken on master (I noticed this while testing python3.8) in the same way (403 forbidden error). I can also update the .travis.yml configuration to run that particular option as well to ensure it works.

zlatanvasovic commented 4 years ago

The merge system can be a pain in the ass. It shouldn't be conflicted, but it is. :/

zlatanvasovic commented 4 years ago

@MasterOdin I had a typo in my local version of the file, I deleted a quote mark lol. It works well, I undid my last change.