Drop python2 support - Githubissues

tldr-pages / tldr-python-client

:snake: Python command-line client for tldr pages 📚

https://pypi.org/project/tldr/

MIT License

599 stars 95 forks source link

Drop python2 support #93

Closed MasterOdin closed 4 years ago

MasterOdin commented 4 years ago

Given that Python2 was deprecated on January 1st, 2020, and its last version was released a few days ago, I would like to propose removing support in this client for python2, and only focus on python3. Python2 is also being phased out increasingly from various Linux distros to be harder and harder to install. Principally, this would just involve:

changing the shebang to be #!/usr/bin/env python3 instead of #!/usr/bin/env python
remove usage of __future__
remove six as dependency

zlatanvasovic commented 4 years ago

Ubuntu still supports it, so that might be a problem at this phase. But at some point in the future, why not.

MasterOdin commented 4 years ago

The current oldest supported LTS (excluding the extended support they offer for money) is 16.04 which has Python 3.5 out of the box. By the logic of "Ubuntu supports it", that would mean you would remove python2 support at the earliest in 2025 (when 20.04 exits LTS)?

zlatanvasovic commented 4 years ago

You're right, it seems I forgot that python3 was installed by default even in way older versions. Your argument makes complete sense now.

zlatanvasovic commented 4 years ago

@waldyrious @felixonmars any opinions on this? I'm for the change.

felixonmars commented 4 years ago

I'd like to drop support for Python 2 too. PRs welcome!

waldyrious commented 4 years ago

With the EOL of Python2, and Python3 widely available in most systems, I don't see any serious downsides in migrating either :)