search

tldr-pages / tldr-python-client

:snake: Python command-line client for tldr pages 📚
https://pypi.org/project/tldr/
MIT License
599 stars 95 forks source link

Add recommendations for light terminal themes #94

Closed k4j8 closed 4 years ago

k4j8 commented 4 years ago

Update the README to suggest a color configuration for light terminals themes. With the current default settings, the white text is not legible on most light terminal themes.

k4j8 commented 4 years ago

Good point. Although black wasn't an option, "grey dark" was. I tried the following code on all default light themes in Gnome Terminal and like it more. What do you think? If acceptable, I will modify and resubmit.

export TLDR_COLOR_BLANK="grey dark"
export TLDR_COLOR_NAME="grey dark"
export TLDR_COLOR_DESCRIPTION="grey dark"
export TLDR_COLOR_EXAMPLE="blue"     
export TLDR_COLOR_COMMAND="red"
export TLDR_COLOR_PARAMETER="grey dark"

Black on light yellow

black on light yellow

Black on white

black on white

Tango light

tango light

Solarized light

solarized light

Current defaults (bad) - black on white

default settings - black on white

zlatanvasovic commented 4 years ago

As far as I know, black is supported in Bash. Dark grey is fine too, anyway.

MasterOdin commented 4 years ago

As far as I know, black is supported in Bash. Dark grey is fine too, anyway.

This is a quirk of termcolor where it uses the name grey instead of black to represent ANSI code 30.

zlatanvasovic commented 4 years ago

@KyleWJohnston Please review #95 and tell me does it solve some of your concerns.

k4j8 commented 4 years ago

96 implements improvements to light terminals that require different user modifications if any at all, making this PR unnecessary.