[bug] Incorrect bounds for a curved / labeled line when selecting multiple shapes

tldraw / tldraw-v1

A tiny little drawing app. This is the original 2021-2022 version, released under MIT.

https://old.tldraw.com

MIT License

64 stars 35 forks source link

[bug] Incorrect bounds for a curved / labeled line when selecting multiple shapes #114

Closed alex-kim-dev closed 2 years ago

alex-kim-dev commented 2 years ago

The line text isn't inside the bounds:
~~Same for the curved line endings:~~ fixed in tldraw/tldraw#979

steveruizok commented 2 years ago

Just to check: you would expect the bounding box of the arrow to include the label?

alex-kim-dev commented 2 years ago

Yes. Is it by design? I mean, it's not such a big deal, but I think the endings still have to be inside.

steveruizok commented 2 years ago

Hm, yeah, I'm going to say this is sort of by design. If we did measure the text as part of the bounds checking, it could have an impact in other arrow behaviors, so it would take some time to implement.

alex-kim-dev commented 2 years ago

ok, I think I'll close this for now