[bugfix] don't crash if a bound shape doesn't exist - Githubissues

tldraw / tldraw

SDK for creating whiteboards and canvas experiences on the web.

https://tldraw.dev

Other

33.04k stars 1.98k forks source link

[bugfix] don't crash if a bound shape doesn't exist #3653

Closed ds300 closed 2 weeks ago

ds300 commented 2 weeks ago

We saw this in r/ok

somehow an arrow was created where the boundShapeId was pointing to a shape that doesn't exist
we do need to be tolerant of such situations until our server can enforce binding constraints
so let's not use ! here

Change Type

[x] sdk — Changes the tldraw SDK
[x] dotcom — Changes the tldraw.com web app
[ ] docs — Changes to the documentation, examples, or templates.
[ ] vs code — Changes to the vscode plugin
[ ] internal — Does not affect user-facing stuff

[x] bugfix — Bug fix
[ ] feature — New feature
[ ] improvement — Improving existing features
[ ] chore — Updating dependencies, other boring stuff
[ ] galaxy brain — Architectural changes
[ ] tests — Changes to any test code
[ ] tools — Changes to infrastructure, CI, internal scripts, debugging tools, etc.
[ ] dunno — I don't know

Test Plan

I copied the data from /r/ok and loaded it and this fixed the error

Release Notes

fixes an edge case in multiplayer rooms where the room can crash if an arrow's bound shape is deleted by a peer

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
examples	✅ Ready (Inspect)	Visit Preview	Apr 30, 2024 10:14am

1 Ignored Deployment

| Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **tldraw-docs** | ⬜️ Ignored ([Inspect](https://vercel.com/tldraw/tldraw-docs/FMHBWGQeKmYFtMiWA4DfhpC1yxdD)) | | Apr 30, 2024 10:14am |