This PR seeks to make it easier to disentangle shape selection logic from the grouping shapes logic. This is one of two approaches we could take to this problem.
I think this is a better method because it doesn't require consumers of the library with their own custom actions to change the way their own grouping logic works. As evidenced by all the tests failing on the other PR.
Change Type
[x] sdk — Changes the tldraw SDK
[ ] dotcom — Changes the tldraw.com web app
[ ] docs — Changes to the documentation, examples, or templates.
[ ] vs code — Changes to the vscode plugin
[ ] internal — Does not affect user-facing stuff
[ ] bugfix — Bug fix
[ ] feature — New feature
[x] improvement — Improving existing features
[ ] chore — Updating dependencies, other boring stuff
[ ] galaxy brain — Architectural changes
[ ] tests — Changes to any test code
[ ] tools — Changes to infrastructure, CI, internal scripts, debugging tools, etc.
[ ] dunno — I don't know
Test Plan
Add a step-by-step description of how to test your PR here.
This PR seeks to make it easier to disentangle shape selection logic from the grouping shapes logic. This is one of two approaches we could take to this problem.
Other PR is here: https://github.com/tldraw/tldraw/pull/3691
I think this is a better method because it doesn't require consumers of the library with their own custom actions to change the way their own grouping logic works. As evidenced by all the tests failing on the other PR.
Change Type
sdk
— Changes the tldraw SDKdotcom
— Changes the tldraw.com web appdocs
— Changes to the documentation, examples, or templates.vs code
— Changes to the vscode plugininternal
— Does not affect user-facing stuffbugfix
— Bug fixfeature
— New featureimprovement
— Improving existing featureschore
— Updating dependencies, other boring stuffgalaxy brain
— Architectural changestests
— Changes to any test codetools
— Changes to infrastructure, CI, internal scripts, debugging tools, etc.dunno
— I don't knowTest Plan
Release Notes