tlefko / XPS13-9350-Catalina

Files for Catalina Installation
Eclipse Public License 2.0
27 stars 4 forks source link

Wake from Sleep-Black Display #2

Closed Saad-LUMS closed 4 years ago

Saad-LUMS commented 4 years ago

Hey @tlefko I wiped my Mojave install and fresh installed Catalina using your files. Everything works great, trackpad, brightness, sound from speakers (combojack not working though). Combojack works using the installer from Maz-1, check the sound issue thread for anyone interested. However wake from sleep both using lid and menu, results in black screen leading to need for hard reboot.

tlefko commented 4 years ago

@Saad-LUMS I'm so sorry for me it didn't happen, I'll dig around and get back to you

Saad-LUMS commented 4 years ago

Let me know if there's any progress and if I can be of any help. If it does not work, it's fine. Catalina actually does seem snappier than Mojave for some reason and the bug from Mojave of long authentication that was plaguing me is also gone now. So, I'm happy!

tlefko commented 4 years ago

@Saad-LUMS I told you its so strange but its much, much faster

tlefko commented 4 years ago

@Saad-LUMS by the way did you encounter any other bugs? //was the guide easy to follow

Saad-LUMS commented 4 years ago

The guide was very easy. No bugs so far. Will keep you posted. However, there are a couple of changes I would suggest.

  1. You should add my finding from insanelymac regarding stock card and kernel panic in your guide as pre-install step (as I suggested in that thread, check it out).

  2. You should mention that the files have to be placed inside newly created folders called EFI (since you don't say to install Clover which would create the folder itself) inside the EFI partitions both in the installer USB and SSD, otherwise the installer disk image and installed Catalina partition will not be detected and shown in Clover upon boot. I made this mistake!

Saad-LUMS commented 4 years ago

20200229_113312 You can clearly see the com.apple.driver.Airport.brcmNIC in the fourth line at the top before restarting at the end.

tlefko commented 4 years ago

@Saad-LUMS updated readme

Saad-LUMS commented 4 years ago

Read it. Much simpler for newbies.

Saad-LUMS commented 4 years ago

Also, yes the solution to sleep-wake could be related to ID's. Is your XPS same as mine? If it is then it should for me too. Or perhaps the DSDTs are not fully compatible. i5 6200U, QHD+ Touch, Samsung PM951 256GB SSD, 8 GB Ram.

tlefko commented 4 years ago

Same model yep @Saad-Lums, I also have i7

Saad-LUMS commented 4 years ago

I just tried adjusting the brightness after waking from sleep using lid. The backlight goes up and down (grey level) but no image of the UI. Also, Syscl's files gave perfect support for sleep-wake in Mojave on this system (other issues notwithstanding). Might get a lead by looking them over.

tlefko commented 4 years ago

@Saad-LUMS I just spoke to another user who has no seem wake bugs oncesoever with this build. It's so unusual. I tried syscls patches for lidwake but to no avail. I also had sleep wake bugs on Mojave. I tried adjusting the framebuffer but no luck. He has the same GPU as us so I'm really not sure what's different other than his resolution.

Saad-LUMS commented 4 years ago
Screen Shot 2020-03-25 at 1 07 51 PM

Could these settings I've set be doing something to prevent sleep from working? Really shouldn't have any effect on sleeping from the menu.

Saad-LUMS commented 4 years ago

Nothing doing. Tried with different power settings. Also, I recall the first thing I did after fresh installing Catalina was testing sleep with default settings. So, still a no go.

Saad-LUMS commented 4 years ago

Off topic but I just installed 10.15.3, 3 days back thinking it would stay for a while and just yesterday 10.15.4 got released. Now, there's the annoying notification bubble on Settings app in the Dock triggering my OCD :D

tlefko commented 4 years ago

@Saad-LUMS I really want to solve this issue

Saad-LUMS commented 4 years ago

He has the same GPU as us so I'm really not sure what's different other than his resolution.

Maybe the difference in CPU is to blame since I have an i5. Does the other person have an i7 like you?

tlefko commented 4 years ago

@Saad-LUMS he does, it's so so strange.

Saad-LUMS commented 4 years ago

So, something, somewhere is not playing nice with my i5. Not fully compatible. Maybe some DSDT/SSDT combination.

Saad-LUMS commented 4 years ago

Do you guys have HD 520 or some other igpu?

tlefko commented 4 years ago

@Saad-LUMS hd 520. ... I really am not sure

tlefko commented 4 years ago

But the bug is on mine as well it just didn't happen on the first boot @Saad-LUMS so it's not just you

Saad-LUMS commented 4 years ago

Also, I did not use Catalina Patcher app to make the USB installer. I just used it to download the image and used createinstallmedia command in terminal since I don't want the patches it will add to the installer. Kept it vanilla.

Saad-LUMS commented 4 years ago

@tlefko Did you delete your comment regarding the fix? I got an email for it. Can't find it here. Was it not fixed? Anyway, I tried 3 steps, can't figure out how to patch framebuffer. With the 3 steps done, no fix as of yet.

  1. Inject Intel was already checked.

  2. Deleted Boot argument for backlight.

    Screen Shot 2020-03-27 at 12 43 23 PM
  3. Changed ig-platform-id:

    Screen Shot 2020-03-27 at 12 44 34 PM

Do I change the hex here for framebuffer patching and enable it? I tried, didn't work, disabled it.

Screen Shot 2020-03-27 at 12 45 27 PM

I also tried inserting into fake ID for intel GFX but that made the 520 show 20 mb memory and the brightness and resolution did not work properly. The display also showed up as a projector, so that's not it.

Screen Shot 2020-03-27 at 12 45 51 PM
tlefko commented 4 years ago

@Saad-LUMS I deleted the email for the fix as it did not work lol. I really am completely stumped. I tried looking at syscl's stuff and at HWPenable and all sorts of stuff and can't find anything. Also I've noticed a weird thing where preformance is worse on battery when it's below 80 percent, I think it's related to the display. Have you noticed anything?

Saad-LUMS commented 4 years ago

In regards to performance, I had my machine repaired a year ago when it went up in smoke (the board) and ever since then, it's performance has been terrible, stuttery and laggy on battery, okay >80% but way worse as it get's lower (perfect when plugged in). The battery has also gone down in quality and needs to be replaced so that could also be a culprit in poor performance on battery. So, I don't think it can be compared to a stock machine. However, performance on battery on MacOS has been much better than in Windows for me. There is a negligible difference between battery and plugged-in.

tlefko commented 4 years ago

@Saad-LUMS oh wow, well I guess that's not a good benchmark. Either way, the sleep wake thing is the biggest issue it is driving me insane. I think it has to do with USB issues

tlefko commented 4 years ago

@Saad-LUMS okay, I have a new clover config if you want to test it. Improves performance and improves the sleep wake issue. Basically, if you close the lid and try to open it right away it does work, but you're no longer stuck after a black screen. Just let the lid close for 15-20 seconds and reopen and press a key and it will work. no more need for a restart. this build also fixed eject usb on sleep. it's a solid upgrade if you want to try it. There seems to small graphical glitches though after wakeup..

Saad-LUMS commented 4 years ago

Sure, let me test it.

tlefko commented 4 years ago

@Saad-LUMS ill send you my clover files, just fix the serial etc before you actually use it

untitled folder 2.zip

this should really improve your performance, even with the board It should be a major improvement. let me know. the sleep wake works it is just super finicky

Saad-LUMS commented 4 years ago

No improvement on the sleep front. Leaving for 15-20 seconds still brings up a black screen and pressing keys makes notification/error sounds as before. Will need to use it a bit for performance review (I can hear the fan more now).

tlefko commented 4 years ago

@Saad-LUMS try this, when the lid is open. Press the power button when you see that black screen. It should go to a blank screen with no blacklight. Then close the lid and open and it and repeat. This should work.

Saad-LUMS commented 4 years ago

I've reverted back to the old, original files as I found that sometimes, the new files would get stuck at boot until it completely borked it and would boot to a black screen (most likely resuming from sleep). The trick with the lid had no effect on the original files. Also, I've noticed another issue with both files. Sleeping on battery, shuts down the machine, both using menu and lid, for some reason. I'm okay without sleep though, as is not as useful as hibernation which does not work on hackintoshes anyway. I use Aerial screensaver, have set a custom key combo for it and use it to lock the laptop when I'm away whilst it's plugged in.