tlenclos / react-native-audio-streaming

iOS & Android react native module to play an audio stream, with background support and media controls
MIT License
781 stars 255 forks source link

PropTypes issue for React 16.0+ #111

Open dmtrKovalenko opened 6 years ago

dmtrKovalenko commented 6 years ago

What about moving to PropTypes package instead of react`s?

yogendrakarekar commented 6 years ago

This library "react native audio streaming" is not upgraded to suit with react-native 0.49.1, Please upgrade.it gives prototype error. following is the error i am getting undefined is not an object(evaluating '_react3.default.proptypes.string'). please help, atleast tell which native version to use.

polp6880 commented 6 years ago

@yogendrakarekar from the tests I did, this works without issues with react native version 0.47.2. All of my tests in versions higher than that failed.

yogendrakarekar commented 6 years ago

Hi,

Thank you so much, will try with 0.47.2

Thanks & Regards Yogendra U. Karekar Mobile:-9769856284 Email:-yogendra.karekar@gmail.com

On Sat, Oct 14, 2017 at 7:34 PM, polp6880 notifications@github.com wrote:

@yogendrakarekar https://github.com/yogendrakarekar from the tests I did, this works without issues with react native version 0.47.2. All of my tests in versions higher than that failed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tlenclos/react-native-audio-streaming/issues/111#issuecomment-336636914, or mute the thread https://github.com/notifications/unsubscribe-auth/AMhrFZphdk1QGQAnhKvs0WLpfCFoB5lKks5ssL-LgaJpZM4PDhdw .

yogendrakarekar commented 6 years ago

Tried it with react native 0.47.2 but it gives me :cfbundleidentifier issue, so I tried with 0.44.0 and YES REACT-NATIVE-AUDIO-STREAMING WORKS !, but I am not sure whether my other plugins will work or not, I have started to hate React native

polp6880 commented 6 years ago

@yogendrakarekar that sounds a bit strange - I did not run into this issue. I have to point out however that I have no other libraries in my project. It's literally a new React Native app (not using Expo) with this particular library installed.

theeomm commented 6 years ago

It works with the most recent version of react native if you install the package as npm i -S https://github.com/tlenclos/react-native-audio-streaming#master