search

tlenclos / react-native-audio-streaming

iOS & Android react native module to play an audio stream, with background support and media controls
MIT License
783 stars 254 forks source link

Can master become a release? #119

Open johncblandii opened 6 years ago

johncblandii commented 6 years ago

I don't like targeting https://github.com/tlenclos/react-native-audio-streaming#master. Can master get a release? It has been 7+ months since the last one.

Thanks. The library seems to work well. I'll test more soon.

salisuabubakar commented 6 years ago

hello @johncblandii can you please give me the steps to target master. am unable to use it. thanks

johncblandii commented 6 years ago

"react-native-audio-streaming": "https://github.com/tlenclos/react-native-audio-streaming#master"

Add that to your package.json under dependencies.

johncblandii commented 6 years ago

@salisuabubakar https://docs.npmjs.com/files/package.json#git-urls-as-dependencies

salisuabubakar commented 6 years ago

i have changed the dependency to "react-native-audio-streaming": "https://github.com/tlenclos/react-native-audio-streaming#master" in package.son and restarted the packages but still the same error. Please help . Thanks for your time screenshot_2017-11-19-22-32-38

johncblandii commented 6 years ago

Try clearing your packager cache after removing node_modules.

Steps:

> watchman watch-del-all
> rm -rf node_modules/
> npm cache clean
> npm install
> npm start -- --reset-cache

Just in case. This is the nuke option but would help make sure it isn't a cache issue.

salisuabubakar commented 6 years ago

i have clear the cash but when i do npm install i get below error. Also i have attached my package.json file. Thanks

================================================= C:\Users\salisu\Desktop\REACT TESTING\ClickRadio>npm install npm WARN addRemoteGit Error: not found: git npm WARN addRemoteGit at getNotFoundError (C:\Program Files\nodejs\node_modules\npm\node_modules\which\which.js:14:12) npm WARN addRemoteGit at F (C:\Program Files\nodejs\node_modules\npm\node_modules\which\which.js:69:19) npm WARN addRemoteGit at E (C:\Program Files\nodejs\node_modules\npm\node_modules\which\which.js:81:29) npm WARN addRemoteGit at C:\Program Files\nodejs\node_modules\npm\node_modules\which\which.js:90:16 npm WARN addRemoteGit at C:\Program Files\nodejs\node_modules\npm\node_modules\which\node_modules\isexe\index.js:44:5 npm WARN addRemoteGit at C:\Program Files\nodejs\node_modules\npm\node_modules\which\node_modules\isexe\windows.js:29:5 npm WARN addRemoteGit at C:\Program Files\nodejs\node_modules\npm\node_modules\graceful-fs\polyfills.js:264:29 npm WARN addRemoteGit at FSReqWrap.oncomplete (fs.js:123:15) npm WARN addRemoteGit git+ https://github.com/tlenclos/react-native-audio-streaming.git#master resetting remote C:\Users\salisu\AppData\Roaming\npm-cache_git-remotes\git-https-github-com-tlenclos-react-native-audio-streaming-git-master-276909a4 because of error: { Error: not found: git npm WARN addRemoteGit at getNotFoundError (C:\Program Files\nodejs\node_modules\npm\node_modules\which\which.js:14:12) npm WARN addRemoteGit at F (C:\Program Files\nodejs\node_modules\npm\node_modules\which\which.js:69:19) npm WARN addRemoteGit at E (C:\Program Files\nodejs\node_modules\npm\node_modules\which\which.js:81:29) npm WARN addRemoteGit at C:\Program Files\nodejs\node_modules\npm\node_modules\which\which.js:90:16 npm WARN addRemoteGit at C:\Program Files\nodejs\node_modules\npm\node_modules\which\node_modules\isexe\index.js:44:5 npm WARN addRemoteGit at C:\Program Files\nodejs\node_modules\npm\node_modules\which\node_modules\isexe\windows.js:29:5 npm WARN addRemoteGit at C:\Program Files\nodejs\node_modules\npm\node_modules\graceful-fs\polyfills.js:264:29 npm WARN addRemoteGit at FSReqWrap.oncomplete (fs.js:123:15) code: 'ENOGIT' } npm ERR! git clone --template=C:\Users\salisu\AppData\Roaming\npm-cache_git-remotes_templates --mirror https://github.com/tlenclos/react-native-audio-streaming.git C:\Users\salisu\AppData\Roaming\npm-cache_git-remotes\git-https-github-com-tlenclos-react-native-audio-streaming-git-master-276909a4: undefined npm ERR! git clone --template=C:\Users\salisu\AppData\Roaming\npm-cache_git-remotes_templates --mirror https://github.com/tlenclos/react-native-audio-streaming.git C:\Users\salisu\AppData\Roaming\npm-cache_git-remotes\git-https-github-com-tlenclos-react-native-audio-streaming-git-master-276909a4: undefined npm ERR! Windows_NT 6.1.7600 npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install" npm ERR! node v6.10.3 npm ERR! npm v3.10.10 npm ERR! code ENOGIT

npm ERR! not found: git npm ERR! npm ERR! Failed using git. npm ERR! This is most likely not a problem with npm itself. npm ERR! Please check if you have git installed and in your PATH.

npm ERR! Please include the following file with any support request: npm ERR! C:\Users\salisu\Desktop\REACT TESTING\ClickRadio\npm-debug.log

C:\Users\salisu\Desktop\REACT TESTING\ClickRadio>

On Mon, Nov 20, 2017 at 3:51 AM, John C. Bland II notifications@github.com wrote:

Try clearing your packager cache after removing node_modules.

Steps:

watchman watch-del-all rm -rf node_modules/ npm cache clean npm install npm start -- --reset-cache

Just in case. This is the nuke option but would help make sure it isn't a cache issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tlenclos/react-native-audio-streaming/issues/119#issuecomment-345584736, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkUnC8PNHERaNCmrbQfASNmEMLWU3Sgks5s4PdPgaJpZM4P7T2h .

-- Salisu Abubakar Web developer Mobile:0243460126 skype: maloojackson1 Email:salisuabubakar@gmail.com salisuabubakar@inspirecreationsgh.com

johncblandii commented 6 years ago

GitHub doesn't attach files. Paste the contents.

salisuabubakar commented 6 years ago

Below is my package.json content

{ "name": "ClickRadio", "version": "0.0.1", "private": true, "scripts": { "start": "node node_modules/react-native/local-cli/cli.js start", "test": "jest" }, "dependencies": { "react": "16.0.0-beta.5", "react-native": "0.49.1", "react-native-audio-streaming": " https://github.com/tlenclos/react-native-audio-streaming#master", "react-native-vector-icons": "^4.4.2" }, "devDependencies": { "babel-jest": "21.2.0", "babel-preset-react-native": "4.0.0", "jest": "21.2.1", "react-test-renderer": "16.0.0-beta.5" }, "jest": { "preset": "react-native" } }

On Mon, Nov 20, 2017 at 4:38 AM, John C. Bland II notifications@github.com wrote:

GitHub doesn't attach files. Paste the contents.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tlenclos/react-native-audio-streaming/issues/119#issuecomment-345589998, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkUnB4XuSN7jBPnqqJmFmmldjhlOtHZks5s4QJdgaJpZM4P7T2h .

-- Salisu Abubakar Web developer Mobile:0243460126 skype: maloojackson1 Email:salisuabubakar@gmail.com salisuabubakar@inspirecreationsgh.com

salisuabubakar commented 6 years ago

i did git config --global url."https://".insteadOf git:// and i was able to install now. After installing and running react-native run-android app crash during startup.

On Mon, Nov 20, 2017 at 4:40 AM, Salisu Abubakar salisuabubakar@gmail.com wrote:

Below is my package.json content

{ "name": "ClickRadio", "version": "0.0.1", "private": true, "scripts": { "start": "node node_modules/react-native/local-cli/cli.js start", "test": "jest" }, "dependencies": { "react": "16.0.0-beta.5", "react-native": "0.49.1", "react-native-audio-streaming": "https://github.com/tlenclos/ react-native-audio-streaming#master", "react-native-vector-icons": "^4.4.2" }, "devDependencies": { "babel-jest": "21.2.0", "babel-preset-react-native": "4.0.0", "jest": "21.2.1", "react-test-renderer": "16.0.0-beta.5" }, "jest": { "preset": "react-native" } }

On Mon, Nov 20, 2017 at 4:38 AM, John C. Bland II < notifications@github.com> wrote:

GitHub doesn't attach files. Paste the contents.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tlenclos/react-native-audio-streaming/issues/119#issuecomment-345589998, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkUnB4XuSN7jBPnqqJmFmmldjhlOtHZks5s4QJdgaJpZM4P7T2h .

-- Salisu Abubakar Web developer Mobile:0243460126 skype: maloojackson1 Email:salisuabubakar@gmail.com salisuabubakar@inspirecreationsgh.com

-- Salisu Abubakar Web developer Mobile:0243460126 skype: maloojackson1 Email:salisuabubakar@gmail.com salisuabubakar@inspirecreationsgh.com

salisuabubakar commented 6 years ago

@johncblandii Please are you able to use the module with React Native 0.49+? Thanks

johncblandii commented 6 years ago

I have it in an app with 0.48.3 and it works just fine. Another app with 0.49.0 builds just fine but the audio doesn't play. I have not tested whether that is a library issue or the stream.

salisuabubakar commented 6 years ago

Using it with wix react native navigation crash when building it but it is working very well with React navigation and React native 0.51. Thanks

johncblandii commented 6 years ago

Glad it is working, @salisuabubakar. I'm starting to believe this package is dead and am going to move away from it. Hope it continues to work for you.

salisuabubakar commented 6 years ago

Please dont move away from this package. So far it is the best Audio streaming module you can get for react native. Its stable and i love it. Thanks for your time

On Sat, Dec 30, 2017 at 7:51 PM, John C. Bland II notifications@github.com wrote:

Glad it is working, @salisuabubakar https://github.com/salisuabubakar. I'm starting to believe this package is dead and am going to move away from it. Hope it continues to work for you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tlenclos/react-native-audio-streaming/issues/119#issuecomment-354564918, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkUnORxaA_FtfnjYQHvTnPeBuKpiQbJks5tFpQpgaJpZM4P7T2h .

-- Salisu Abubakar Web developer Mobile:0243460126 skype: maloojackson1 Email:salisuabubakar@gmail.com salisuabubakar@inspirecreationsgh.com

johncblandii commented 6 years ago

It is hard not to if the project is stale and the owner is MIA. I'm stuck w/ it in a couple apps for now, but definitely have to get something more stable.

tlenclos commented 6 years ago

Hi there, sorry this module is in fact not maintain for a long time now. I'm not using it anymore and I'm either deprecating it in favor of https://github.com/zmxv/react-native-sound or adding new maintainer if someone is interested.

If I may ask, what is keeping you on this module instead of https://github.com/zmxv/react-native-sound that now supports network streaming ?

johncblandii commented 6 years ago

No problem, @tlenclos. Just hearing back is absolutely helpful.

I believe at the time of trying r-n-s it didn't support live streaming. I don't know if it does now or not, but if it does and is maintained, we will check it out again.

Thx for touching base.

johncblandii commented 6 years ago

@tlenclos the main reason I can't switch this other app to r-n-s is because of the lack of buffering/status updates. I need to know when it is buffering.

tlenclos commented 6 years ago

I see, I think it could easily be added to the library by implementing https://developer.android.com/reference/android/media/MediaPlayer.OnBufferingUpdateListener.html#onBufferingUpdate(android.media.MediaPlayer, int) and passing the message on the JS side.

stavros-zavrakas commented 6 years ago

@tlenclos I have exactly the same issue with the outdate version. The zmxv/react-native-sound was the first module that I've tried but as @johncblandii mention is not supporting buffering/status updates. Do you have any idea if this will be implemented at some point to zmxv/react-native-sound module?

tlenclos commented 6 years ago

None, I suggest creating an issue on the repository / try to implement it.

salisuabubakar commented 6 years ago

Yeah thats exactly what i am saying. React native audio streaming is the best currently. Please dont abandon the project. I have more than three apps using it and it works perfectly. Tnanks

On Jan 25, 2018 1:57 PM, "Thibault Lenclos" notifications@github.com wrote:

None, I suggest creating an issue on the repository / try to implement it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tlenclos/react-native-audio-streaming/issues/119#issuecomment-360473601, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkUnFCbKJBtb-46s2t4aioRJn6nvzQTks5tOIhXgaJpZM4P7T2h .

tlenclos commented 6 years ago

@salisuabubakar I was suggesting implementing it on the most maintained / used package, which is https://github.com/zmxv/react-native-sound 😛

salisuabubakar commented 6 years ago

Oh ok that will not be a bad idear.

On Jan 25, 2018 4:29 PM, "Thibault Lenclos" notifications@github.com wrote:

@salisuabubakar https://github.com/salisuabubakar I was suggesting implementing it on the most maintained / used package, which is https://github.com/zmxv/react-native-sound 😛

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tlenclos/react-native-audio-streaming/issues/119#issuecomment-360520668, or mute the thread https://github.com/notifications/unsubscribe-auth/AGkUnESq5PMcfAgYicoaDNw3FqaNGDUzks5tOKvRgaJpZM4P7T2h .