search

tlenclos / react-native-audio-streaming

iOS & Android react native module to play an audio stream, with background support and media controls
MIT License
783 stars 254 forks source link

Can we make notification on android and media center control on iOS optional ? #27

Closed madhu314 closed 7 years ago

madhu314 commented 7 years ago

Was wondering if the play method can take extra parameter to control notification on android and media center on ios ?

currently the default behavior is to always show notification and there is no way to override it ?

Are there any plans for such enhancements for this library ? I really like this library and hope to see this enhancement of optional notifications/media center control. If you agree, I can work on a PR

tlenclos commented 7 years ago

You are right this should be optional, you can work on it if you want. 😃

madhu314 commented 7 years ago

coool, I will give it a go.

madhu314 commented 7 years ago

I have submitted a PR , please have a look

tlenclos commented 7 years ago

Fixed with release https://github.com/tlenclos/react-native-audio-streaming/releases/tag/v2.2.0, thanks !