Use ExoPlayer instead of AACdecoder for android

tlenclos / react-native-audio-streaming

iOS & Android react native module to play an audio stream, with background support and media controls

MIT License

783 stars 254 forks source link

Use ExoPlayer instead of AACdecoder for android #44

Open tlenclos opened 7 years ago

tlenclos commented 7 years ago

This PR replace the old aacdecoder library with the ExoPlayer actively maintained and published by Google. This will allow us to add more controls and format support.

TODO

[ ] Handle ID3 metadata (available in next release probably https://github.com/google/ExoPlayer/commit/ced03e9ad56f572de967b220e78887815bee457c)
[ ] Handle shoutcast stream (someone succeeded with the V2 https://github.com/google/ExoPlayer/issues/466#issuecomment-290358993)
[ ] Feature parity with iOS (url, progress, duration)

smkhalsa commented 7 years ago

@tlenclos any update on this?

Arkanine commented 7 years ago

There is another module which use ExoPlayer https://github.com/indiecastfm/react-native-audio-streamer you can get some idea from there.

ronunism commented 6 years ago

Any word on this getting approved/merged in?

M4rcDev commented 6 years ago

Any updates?

addingama commented 6 years ago

@tlenclos how can I contribute to make this PR mergeable?

I'd love to see this feature implemented

Some of my streaming url cannot be played (http://ltr.tac9.ca:8000/skytrain) and if the url need to be redirected to another url, the streaming cannot play (relay.broadcastify.com/yk04v37m2bj1wgp) I hope exo player can solve this problem

tlenclos commented 6 years ago

@dashracer have you tried the other modules available that are using exo player ? I'm not currently maintaining this project and the only purpose was to support shoutcast meta data. I guess that other modules have more functionality and stability.

If you plan to contribute you can fork this branch and submit a new PR. Even better if you want to to maintain this project I can give you the access.