search

tlenclos / react-native-audio-streaming

iOS & Android react native module to play an audio stream, with background support and media controls
MIT License
783 stars 254 forks source link

Android app crashed when trying to update metadata with notification not initialized #75

Closed IndrekV closed 7 years ago

IndrekV commented 7 years ago

Currently when android notification is turned off showInAndroidNotifications: false

App crashes when you start the player. This happens because player tries to update remoteViews that refers to the notification that is null.

This fix will avoid trying to update the remoteViews

tlenclos commented 7 years ago

Thanks !

yasheshkt commented 7 years ago

Thanks a lot for the Fix @IndrekV . I am just wondering when will the new changes get published to NPM? I am using this plugin in one of my app. For now I have made changes in node_modules folder. But it is good if this gets updated on NPM as well.

Thanks for the awesome work on this :)