search

tlenclos / react-native-audio-streaming

iOS & Android react native module to play an audio stream, with background support and media controls
MIT License
781 stars 255 forks source link

Android exoplayer #88

Closed cherniv closed 6 years ago

cherniv commented 7 years ago

Method getStatus response includes duration and progress

tlenclos commented 7 years ago

Hi @cherniv Thanks a lot for your work, I will try to make a minor release with bugfixes without exoplayer and then a major release with it.

Could you fix the indentation issues so that we can read the diff properly ?

vshjxyz commented 7 years ago

Hey guys, I've had a bit of a play on @cherniv's branch, adding "pause on bluetooth disconnect" "pause when removing headphones" and other fixes, will try to build a PR against this branch so you can check it out - works great tho! nice job

cherniv commented 7 years ago

@tlenclos i really don't know what happened with the indentations.. i've used both xcode and sublime and looks like they are messing up files formations. what can be done to fix it ? i'm not sure i want to pass on it manually if this is the only solution.. @vshjxyz cool!

tlenclos commented 7 years ago

@cherniv you could just revert the changes with git, using a GUI for example.

cherniv commented 7 years ago

@tlenclos sorry I'm not a big git master. Do you mean I have to choose bad lines from problematic commits and revert them and then create new commit and push it to my forked repo?

tlenclos commented 7 years ago

@cherniv Yes please. Otherwise it's just too hard to see exactly your changes.

cherniv commented 7 years ago

@tlenclos hey, can you see if it is better now? thanks

catalinmiron commented 6 years ago

any progress?

tlenclos commented 6 years ago

@cherniv thanks for all your work, I will merge and start from this

tmaly1980 commented 6 years ago

@tlenclos What's required to merge this branch with master? Or in the meantime, can I simply use this branch in my project?

guiyom19 commented 6 years ago

Will it be a 2.3.3 release with this exoplayer branch ?