tleonardi / nanocompore

RNA modifications detection from Nanopore dRNA-Seq data
https://nanocompore.rna.rocks
GNU General Public License v3.0
78 stars 12 forks source link

Bug in min_coverage filter #138

Closed tleonardi closed 4 years ago

tleonardi commented 4 years ago

If a ref_id is completely missing from one of the eventalign files it is not filtered out by the Whitelisting function as it should be.

This is due to the fact that the cond_lab and and sample_lab for the missing condition are not present in ref_dict, and therefore the assertion error is never raised.

https://github.com/tleonardi/nanocompore/blob/9f8effec65cbd5347f5ac7e1625164389adad866/nanocompore/Whitelist.py#L242-L246