search

tlestang / heatcompact3d

3D heat equation with 6th order compact schemes
https://tlestang.github.io/heatcompact3d/
GNU General Public License v3.0
0 stars 1 forks source link

Abstract interface and method implementations must mach #11

Closed pbartholomew08 closed 1 year ago

pbartholomew08 commented 1 year ago

Abstract interface of integrate was missing allocatable on the field object.

Chose to make the field allocatable in the interface as this was used in all implementations, if inverse is intended will update pull request.

tlestang commented 1 year ago

Good catch. I'm surprised that it compiles fine with GNU despite the interface being wrong.

For info the reason field_type dummy arguments are allocatable is because their are use on the left side of polymorphic intrinsic assignments.