tleunen / eslint-import-resolver-babel-module

Custom eslint resolve for babel-plugin-module-resolver

https://github.com/tleunen/babel-plugin-module-resolver

MIT License

248 stars 31 forks source link

chore: Update babel-plugin-module-resolver peerdep to allow v4 #108

Closed nappy closed 4 years ago

nappy commented 4 years ago

Since babel-plugin-module-resolver v4 is released, the peer dependency should be updated accordingly. Please review, whether ^3.0.0 should be "or"ed too, and whether there are any compatibility issues. I have not noticed any so far, and the diff between 3 and 4 is also very minor.

codecov[bot] commented 4 years ago

Codecov Report

Merging #108 into master will not change coverage. The diff coverage is n/a.

tleunen commented 4 years ago

You're right, the only "breaking change" is the fact that we officially dropped Node 6. Most users shouldn't be affected by this.

Thanks for the PR, I'll keep it open for now as I'd like to upgrade all of the other dependencies as well at the same time before releasing a new version here

nappy commented 4 years ago

I understand that you want to upgrade other dependencies instead of merging just this PR, but I think it should be done rather sooner than later. The current situation is, that you get an error/unmet peer dependency when using both packages at their latest version. The other dependencies are automatically resolved by npm. Unmet peer dependencies, however need to be fixed manually.

tleunen commented 4 years ago

Yup, agreed. Sorry. Could you please update the range to allow v3 and v4?, and I'll merge it. Thanks!