search

tleunen / eslint-import-resolver-babel-module

Custom eslint resolve for babel-plugin-module-resolver
https://github.com/tleunen/babel-plugin-module-resolver
MIT License
248 stars 31 forks source link

npm update #73

Closed andrevenancio closed 6 years ago

andrevenancio commented 6 years ago

Not sure I'm missing something but when I run npm i --save eslint-import-resolver-babel-module I get the version 4.0.0-beta.3

This version requires me to install peerDependency as per the warning

npm WARN eslint-import-resolver-babel-module@4.0.0-beta.3 requires a peer of babel-plugin-module-resolver@>3.0.0-beta but none is installed. You must install peer dependencies yourself.

However running npm i --save babel-plugin-module-resolver@3.0.0-beta return an error

npm ERR! code ETARGET
npm ERR! notarget No matching version found for babel-plugin-module-resolver@3.0.0-beta
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

Am I missing something?

reohjs commented 6 years ago

I think it's a semver issue - the peerDependency should be ^3.0.0-beta.0

Though, even after installing beta.0, I'm getting has incorrect peer dependency babel-core@^6.0.0 cause I have ^7.0.0-beta.2 but the constraint is set to ^6.0.0 || >7.0.0-alpha...

edit - checked semver again. ^3.0.0-beta should work.. I think it's just the fact that there is no 3.0.0-beta release for babel-plugin-module-resolver

tleunen commented 6 years ago

Yes, I'm sorry. I messed up one release, and when removing the version. The latest on npm was reset to a beta version instead of the v3. I'll work on releasing final versions for both the babel plugin and the eslint plugin today to make it clear. In the meantime, if you're using a beta version for one or the other, you need the beta version for the other one too.

ctavan commented 6 years ago

@tleunen the incorrect tag is causing some trouble for modules using automated dependency updating mechanisms. Would you mind correcting the latest label or is the v3 coming in the next days anyways?

tleunen commented 6 years ago

Yes, we need to fix #74 first, I'll investigate again tonight. We released officially the babel plugin, so an official release of the eslint plugin will come soon, once we fix the issue as I said. I didn't plan that one :( Ideally, both would have been updated at the same time

rkirsling commented 6 years ago

Any further word on this?

rkirsling commented 6 years ago

This shouldn't be closed until v4 is released...? "You can't simply use this package without locking its version" is an outstanding issue which seems to only be tracked here.

tleunen commented 6 years ago

Agreed. I plan to release v4 with a support for Babel 6 only, and a v5 beta for Babel 7. More info tomorrow, and I'm really sorry for the silence and delay with this. I've been very busy lately.

tleunen commented 6 years ago

v4 has been released with babel 6 only. v5.beta with babel 7 will be published very soon.