search

tleunen / eslint-import-resolver-babel-module

Custom eslint resolve for babel-plugin-module-resolver
https://github.com/tleunen/babel-plugin-module-resolver
MIT License
248 stars 31 forks source link

Please patch 4.0.0 release with peer dep babel-plugin-module-resolver upgraded from ^3.0.0-beta to latest stable ^3.0.0 #90

Open hulkish opened 6 years ago

hulkish commented 6 years ago

I have done this work via https://github.com/hulkish/eslint-import-resolver-babel-module/commit/b8da48420461028e39dc106998b982f25866535a. However, since there is no 4.0.0 branch, I can't open a PR to backport this change to 4.x. I'm making this issue instead to request this change. Thanks!

tleunen commented 6 years ago

Thank you for opening a PR about it. I agree that currently this is not ideal, and I had a few things in my personal life which prevented me from keeping these 2 projects up to date with an acceptable state. I'll try to get back at it as soon as I can. But to be honest, instead of patching v4.0.0, I'll probably go with the current v5 (which uses Babel 7).

Did you try updating to the v5 pre release to see if this unblocks you?

hulkish commented 6 years ago

Babel 7 is not an option for my work projects because it is still.in beta. While its very stable and looking great so far - it is called beta for a reason. I need essentially a babel 6 solution.

Since v5 replaces babel 6 with babel 7 - its not guaranteed to be backward compatible. And frankly, welcomes side effects (since we are using babel 6).

This also kind of leaves 4.0.0 in a weird state - of using a beta package.