search

tleunen / eslint-import-resolver-babel-module

Custom eslint resolve for babel-plugin-module-resolver
https://github.com/tleunen/babel-plugin-module-resolver
MIT License
248 stars 31 forks source link

Any chance we can get v5 as a latest release? #97

Closed dlong500 closed 5 years ago

dlong500 commented 5 years ago

There hasn't been an update to the beta series of v5 since last August. That version has been working for me, but I'm wondering why it hasn't made it out of beta for so long. Is there something holding it back or is it unstable in some way?

tunnckoCore commented 5 years ago

Seems to fix the 

Test Suites: 1 skipped, 11 passed, 11 of 18 total
Tests:       1 skipped, 11 passed, 12 total
Snapshots:   0 total
Time:        7s[eslint-import-resolver-babel-module] TypeError: Cannot read property 'find' of undefined
    at result.plugins.filter.plugin (/home/charlike/develop/mono/node_modules/eslint-import-resolver-babel-module/lib/index.js:20:50)
    at Array.filter (<anonymous>)
    at getPlugins (/home/charlike/develop/mono/node_modules/eslint-import-resolver-babel-module/lib/index.js:19:27)

(above while running through jest)

and with just eslint

[eslint-import-resolver-babel-module] TypeError: Cannot read property 'find' of undefined
    at result.plugins.filter.plugin (/home/charlike/develop/mono/node_modules/eslint-import-resolver-babel-module/lib/index.js:20:50)
    at Array.filter (<anonymous>)
    at getPlugins (/home/charlike/develop/mono/node_modules/eslint-import-resolver-babel-module/lib/index.js:19:27)
    at Object.exports.resolve (/home/charlike/develop/mono/node_modules/eslint-import-resolver-babel-module/lib/index.js:69:23)
    at v2 (/home/charlike/develop/mono/node_modules/eslint-module-utils/resolve.js:94:23)
    at withResolver (/home/charlike/develop/mono/node_modules/eslint-module-utils/resolve.js:99:16)
    at fullResolve (/home/charlike/develop/mono/node_modules/eslint-module-utils/resolve.js:116:22)
    at relative (/home/charlike/develop/mono/node_modules/eslint-module-utils/resolve.js:61:10)
    at resolve (/home/charlike/develop/mono/node_modules/eslint-module-utils/resolve.js:180:12)
    at checkSourceValue (/home/charlike/develop/mono/node_modules/eslint-plugin-import/lib/rules/no-unresolved.js:42:50)
See: https://github.com/tleunen/eslint-import-resolver-babel-module/pull/34

issue for me. So it looks like it worth releasing it as latest.

tleunen commented 5 years ago

Yes, I'll make a release tonight. Thanks for the reminder @dlong500 and @tunnckoCore

tleunen commented 5 years ago

v5 released. Thank you.