tleunen / react-mdl

React Components for Material Design Lite
https://tleunen.github.io/react-mdl/
MIT License
1.76k stars 255 forks source link

adds "offsets" Cell component #323

Closed Undeadlol1 closed 8 years ago

tb commented 8 years ago

@Undeadlol1 nice feature but "eslint docs src scripts" is failing the CI

Undeadlol1 commented 8 years ago

@tb what does it mean? What is needed to be done? Refactor according to eslint settings?

tleunen commented 8 years ago

Indeed, it will be best to fix these small issues:

./src/Grid.js
  40:30  error  Unexpected block statement surrounding arrow body  arrow-body-style
  40:30  error  Missing space after =>                             arrow-spacing
  40:66  error  Missing semicolon                                  semi

Thanks for your contribution!

codecov-io commented 8 years ago

Current coverage is 99.84%

Merging #323 into master will increase coverage by <.01%

@@             master       #323   diff @@
==========================================
  Files            55         55          
  Lines           634        636     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            633        635     +2   
  Misses            1          1          
  Partials          0          0          

Powered by Codecov. Last updated by b44f6bb...4e80f28

Undeadlol1 commented 8 years ago

Done and done

tleunen commented 8 years ago

Thanks @Undeadlol1, I'll merge it tonight after adding the new props in the documentation :)

Undeadlol1 commented 8 years ago

@tleunen cool, thank you