search

tleunen / react-mdl

React Components for Material Design Lite
https://tleunen.github.io/react-mdl/
MIT License
1.76k stars 255 forks source link

Update react and react-dom #332

Closed drager closed 8 years ago

drager commented 8 years ago

This pull request updates react and react-dom to the latest versions.

tleunen commented 8 years ago

Unless I'm missing something, 15.1.0 is already covered

drager commented 8 years ago

Yeah, they are covered as dependencies in this project but it would be great if peerDependencies also matched them and are not RC versions.

tleunen commented 8 years ago

But the current peerDep also covers 15.1.0.

Not sure to understand why it doesn't cover 15.2.0-rc.1 though :/ https://semver.npmjs.com/

codecov-io commented 8 years ago

Current coverage is 99.84%

Merging #332 into master will not change coverage

@@             master       #332   diff @@
==========================================
  Files            55         55          
  Lines           634        634          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            633        633          
  Misses            1          1          
  Partials          0          0

Powered by Codecov. Last updated by 2f809a3...6d08eab

drager commented 8 years ago

Ah alright, I see. About the 15.2.0-rc.1 not being included might be because it in fact is a Release Candidate and not a stable release. So if you want to cover that as well you can do this: ^15.1.0 || 15.2.0-rc.1. Not sure if you want that?

drager commented 8 years ago

@tleunen: Saw that you updated the dependencies yourself, then you can close this PR?