search

tleunen / react-mdl

React Components for Material Design Lite
https://tleunen.github.io/react-mdl/
MIT License
1.76k stars 255 forks source link

Clarify docs for `DataTable`'s `shadow` prop #371

Closed milotoor closed 8 years ago

milotoor commented 8 years ago

The documentation around the DataTable's shadow prop indicated that its default value was 0. However, omitting the shadow prop and setting it to 0 produced different results-- the former produced no shadow, while the latter added a class of "mdl-shadow--2dp" to the table. This commit clarifies the documentation.

milotoor commented 8 years ago

This is to address issue #364.

codecov-io commented 8 years ago

Current coverage is 99.33% (diff: 100%)

Merging #371 into master will not change coverage

@@             master       #371   diff @@
==========================================
  Files           107        107          
  Lines          2107       2107          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2093       2093          
  Misses           14         14          
  Partials          0          0

Powered by Codecov. Last update 191a863...5e17d8a

tleunen commented 8 years ago

Thank you @milotoor!

milotoor commented 8 years ago

@tleunen No prob!