search

tleunen / react-mdl

React Components for Material Design Lite
https://tleunen.github.io/react-mdl/
MIT License
1.76k stars 255 forks source link

fix: Fix js error when clicking on a tab #376

Closed tleunen closed 8 years ago

tleunen commented 8 years ago

Fixes #347

MDL tabs require a href to be set, so we're using a small hack to make it work without MDL errors.

codecov-io commented 8 years ago

Current coverage is 99.33% (diff: 100%)

Merging #376 into master will not change coverage

@@             master       #376   diff @@
==========================================
  Files           107        107          
  Lines          2114       2114          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2100       2100          
  Misses           14         14          
  Partials          0          0

Powered by Codecov. Last update 9ab92f9...7d8c286

mr-e- commented 7 years ago

I am still seeing this issue in the latest npm package 1.7.2. Is there any other workaround for this?