search

tleunen / react-mdl

React Components for Material Design Lite
https://tleunen.github.io/react-mdl/
MIT License
1.76k stars 255 forks source link

[1.7.0] Clicking on a tab adds #react-mdl-tabs-hack into URL #381

Closed HriBB closed 8 years ago

HriBB commented 8 years ago

It is this code that does it. Had to revert back to v1.6.1 which works as expected with HeaderTabs.

We should find a better solution, or fix it on the mdl side. Appending #react-mdl-tabs-hack to the URL is not an option for me.

tleunen commented 8 years ago

Yay :/ I believe I'll make a monkey patch on the MDL side to remove the href check to show the panels. It doesn't make sense in a react world.

Trying to fix it since the beginning with the href but it definitely doesn't work.

HriBB commented 8 years ago

Yeah mdl@v1 is not very react-friendly. I believe that monkey patch is the only solution for this problem ATM, because I think they wont accept any PRs on the mdl for this. Anyway, let me know how I can help. I can even write the patch if you just point me into the right direction.

tleunen commented 8 years ago

The way I currently patch MDL is by fetching their 1.2.0 version, applying my current patch on it, and then modify the things I have to update. Generating the new MDL version with the changes (with gulp all on the MDL repo). Then creating the patch from the changed files/commits.

I'll try to do this tonight after work, but if you want to do it, go ahead ;)

HriBB commented 8 years ago

Uhh I think I'll leave this one to you :) It would probably take me way too long to get everything right. But I will test as soon as you patch it ;)

I want to focus on missing form components which I require for my app: react-mdl-autocomplete, react-mdl-datetime and fix react-mdl-selectfield to use chips at least.

I really hope they release v2 alpha soon, it's kinda frustrating having to work with v1.

HriBB commented 8 years ago

@tleunen when do you plan to release this? I would like to test it + HeaderTabs ripple effect.

tleunen commented 8 years ago

Sorry @HriBB, I'll probably do it later today.

HriBB commented 8 years ago

@tleunen no worries, did not mean to rush you or anything, I was just wondering when it's gonna be released. Take your time, I know that you've got more important stuff to do :)