search

tleunen / react-mdl

React Components for Material Design Lite
https://tleunen.github.io/react-mdl/
MIT License
1.76k stars 255 forks source link

Style attribute support #386

Open okbel opened 8 years ago

okbel commented 8 years ago

I think every Component should support the style attibute in case we want to add inline styles. i.e Radium

tleunen commented 8 years ago

They should already support it, do you have an example of a component which doesn't support it?

okbel commented 8 years ago

Sure. CheckBox renders a label tag and an input tag.

When I use a style attr in a Checkbox Component the style goes to input. I need access to the parent label tag

screen shot 2016-08-31 at 2 44 18 pm
tleunen commented 8 years ago

Good point, I forgot about that.

It's hard to fix before v2 though. In the end, component should have a custom inputProps instead of applying all props on the input instead of the root element :/