tleunen / react-mdl

React Components for Material Design Lite
https://tleunen.github.io/react-mdl/
MIT License
1.76k stars 255 forks source link

Scrolling header on mobile #389

Closed ahoereth closed 8 years ago

ahoereth commented 8 years ago

Combining <Layout fixedHeader> with <Header scroll> results in the header

Example: http://codepen.io/anon/pen/ALBZBx

I think that is kind of un-intuitiv and also undocumented behavior. Expected behavior for me would be to have it scrolling on desktop & mobile.

Interested in changing this behavior or introducing a new attribute which would allow this?

Regards, Alex

ahoereth commented 8 years ago

Very similar problem for the <Footer /> component:

tleunen commented 8 years ago

Thanks @ahoereth.

For the header, I've tried the example with the basic MDL lib and I can reproduce the exact same issue. See: https://codepen.io/anon/pen/JRYxWx Therefore I'd suggest you to file an issue on the MDL repo to make sure they fix the issue in their v2. https://github.com/google/material-design-lite

About the footer, I don't know yet what are the plans for v2, but in v1, the footer has to be inside the "content", not outside.

ahoereth commented 8 years ago

Thanks thus far. Regarding the footer inside content: When its inside its not sticky to the bottom of the screen. Demo: https://codepen.io/anon/pen/KgdjpB

tleunen commented 8 years ago

I don't think the MDL team made something to make it sticky, but I might be wrong