Safari-only bug: "Attempting to change value of a readonly property"

tleunen / react-mdl

React Components for Material Design Lite

https://tleunen.github.io/react-mdl/

MIT License

1.76k stars 255 forks source link

Safari-only bug: "Attempting to change value of a readonly property" #434

Closed endash closed 7 years ago

endash commented 7 years ago

As a consequence of the commit from a few days ago (b8dfeb), react-mdl is now broken in Safari, at least in version 9.1.2.

It explodes on https://github.com/react-mdl/react-mdl/blob/master/src/utils/mdlUpgrade.js#L24

DirtyHairy commented 7 years ago

I just noticed the same on some stock Android browsers --- me culpa, this didn't show up in my tests :disappointed: . I have put up PR #437 with a fix.

endash commented 7 years ago

Thank you 👍🏻