Question: Why are you not utilizing PureComponent?

tleunen / react-mdl

React Components for Material Design Lite

https://tleunen.github.io/react-mdl/

MIT License

1.76k stars 255 forks source link

Question: Why are you not utilizing PureComponent? #438

Open ivarconr opened 7 years ago

ivarconr commented 7 years ago

Why have you not utilized shouldComponentUpdate and/or React's PureComponent?

Most UI components are state-less and should render the same markup given the same props. By helping react with via shouldComponentUpdate can give rather large performance boost in complex applications.

Would a contribution to fix this be accepted?

tleunen commented 7 years ago

Sure. The library was built before the introduction of PureComponent and it hasn't been updated to this new "component". But a PR to add it would be a great idea.