search

tleunen / react-mdl

React Components for Material Design Lite
https://tleunen.github.io/react-mdl/
MIT License
1.76k stars 255 forks source link

Toggle in Layout changes color depending on the width. #439

Closed tkreis closed 7 years ago

tkreis commented 7 years ago

At 1024px the menu toggle-button's font gets changed to black.

This could cause an expected bugs when a developer doesn't test different layouts and it changes to black unexpected.

Link to the component: https://react-mdl.github.io/react-mdl/components/layout/ Here are two screenshots highlighting the problem: screen shot 2016-11-28 at 11 03 51

screen shot 2016-11-28 at 11 04 01

tleunen commented 7 years ago

Looks like it's an issue in the Material Design Lite project itself. Can you report the issue there please?

See these lines: Default color: https://github.com/google/material-design-lite/blob/mdl-1.x/src/layout/_layout.scss#L197

Hardcoded to black under the media query: https://github.com/google/material-design-lite/blob/mdl-1.x/src/layout/_layout.scss#L213