search

tleunen / react-number-editor

Custom number editor (text field) react component
MIT License
70 stars 15 forks source link

Controllable #10

Closed cranesandcaff closed 9 years ago

cranesandcaff commented 9 years ago

Finished removing internal value, removed internal valueStr and instead handle in render method of component.

Had to change the proptype to string or number because keyboard entry casts as string. Maybe it could move to the parent components onChange but this seems to work fine. Let me know if you'd like any changes.

cranesandcaff commented 9 years ago

Actually don't merge this...I'm not sure if it's how I'm requiring it(using meteor so NPM is weird with versions...) or if I didn't fix the issue yet.

cranesandcaff commented 9 years ago

I'm closing this so I can merge into the controllable branch instead of master. Also fixing another issue I discovered with the drag method that caused a number to escalate to the max value.