search

tleunen / react-number-editor

Custom number editor (text field) react component
MIT License
70 stars 15 forks source link

Infinite loop when value prop is number #23

Closed rumman23 closed 8 years ago

rumman23 commented 8 years ago

Dragging causes infinite loop when value prop is passed as number(prop change fires onValueChange callback immediately). Same works well when prop is string. I suspect that this is caused by strict comparison of values in _changeValue.

tleunen commented 8 years ago

Thanks for reporting the issue. Any help is welcome to resolve it. I'm quite busy on another project for at least the next few days. Also, we should add tests to prevent this from happening.