tlewis17 / MSFSTouchPortalPlugin

The goal of this repository is to create a connection between Touch Portal and MSFS through SimConnect in order to allow users to create buttons to control or view data for your aircraft. While this is for MSFS, in theory it could be used with other SimConnect compatible games.
MIT License
61 stars 9 forks source link

New update breaks plugin connection #30

Closed p4cm4n closed 3 years ago

p4cm4n commented 3 years ago

Describe the bug As discussed in TP's discord with Ty_Touch-Portal, the new layout update breaks this plugin, also many people is needing to launch MSFS and TP as admin to make it work.

To Reproduce Steps to reproduce the behavior:

  1. Open TP
  2. Connect to ipad
  3. game not connecting

Expected behavior Expected the app to connect automatically, launching the plugins simconnect exe from command line works. from the path %AppData%\TouchPortal\plugins\MSFS-TouchPortal-Plugin\dist>MSFSTouchPortalPlugin.exe

Plugin Version 0.5.2

Screenshots If applicable, add screenshots to help explain your problem. manual connection: image

cusance commented 3 years ago

I agree. The touch portal plugin 5.2 no longer works.

p4cm4n commented 3 years ago

We found out that launching manually the exe from \AppData\Roaming\TouchPortal\plugins\MSFS-TouchPortal-Plugin\dist\ works fine :)

cusance commented 3 years ago

no sorry doesnt work for me. I use it only to get vital stats back onto the IOS touch portal like HDG, ALT, GrnD SPEED etc. Dont know about layout issues as I dont use the page but the plugin no longer connects to MSFS whether started as plugin by TP or the EXE started manually as described above.

p4cm4n commented 3 years ago

@cusance true, the layout is each user's problem, i'll try to update the issue to better reflect the connection problems :)

tlewis17 commented 3 years ago

Try running it manually by:

MSFSTouchPortalPlugin.exe >> log.txt

Attempt a few things like launching MSFS, get in a plane, push a few buttons. Then provide the log file. Remember that if MSFS is running as admin, the plugin has to be running as Admin (and possibly Touch Portal as well).

cusance commented 3 years ago

thanks, at the moment it doesnt connect at all. at least for me.

On 21 Mar 2021, 17:00, at 17:00, p4c m4n @.***> wrote:

true, the layout is each user's problem, i'll try to update the issue to better reflect the connection problems :)

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-803622562

cusance commented 3 years ago

actually I dont think I will bother. As you can see from the screengrab I only use the plugin to get some info back like HDG, speed etc. But I have several Logitech instrument panels working perfectly with SpadNext that give me all this info so I think I will just forget about this plugin for now. I have tried all different ways to connect. Check all authorities, started manually, actually got it to work once but then repeating that same sequence, it didnt work. I have spend now enough time on this. I will wait a few months and then maybe come back to it. All other plugins work fine like OBS etc so it gives me all I need. Eventually I am sure it will work, but not for me now. page

cusance commented 3 years ago

update: I can now get the plugin connected if I do the following: (all running as administrator) after reboot or initial PC start: manually run the plugin.exe then touchportal than msfs So I confirm that it will connect after a manual run.

however if I then close touch portal and msfs and later try this again, the plugin wont connect unless I reboot the PC.. Not very practical but this is all I can do on this. No idea how to fix this but the guys from Touch Portal have confirmed that plugins need to be modified. No idea how. The VLC plugin also was modified.

p4cm4n commented 3 years ago

The plugin appears in the details page of task manager, you can close it from there without the need to reboot, also i managed to run it without administrator account, maybe because i am admin in my system? IDK

El lun, 22 mar 2021 a las 21:39, cusance @.***>) escribió:

update: I can now get the plugin connected if I do the following: (all running as administrator) after reboot or initial PC start: manually run the plugin.exe then touchportal than msfs So I confirm that it will connect after a manual run.

however if I then close touch portal and msfs and later try this again, the plugin wont connect unless I reboot the PC.. Not very practical but this is all I can do on this. No idea how to fix this but the guys from Touch Portal have confirmed that plugins need to be modified. No idea how. The VLC plugin also was modified.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-804378218, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVFH5PEG53O6GEDCAKB2LTE6THJANCNFSM4ZQIT7KA .

cusance commented 3 years ago

yes same here. I know I can close it like that but it would be nice if someone could adjust whatever is needed, to make this run correctly. i don't see that it will run correctly for anyone on the new version of TP. Its beyond my abilities I fear.

On 22 Mar 2021, 22:58, at 22:58, p4c m4n @.***> wrote:

The plugin appears in the details page of task manager, you can close it from there without the need to reboot, also i managed to run it without administrator account, maybe because i am admin in my system? IDK

El lun, 22 mar 2021 a las 21:39, cusance @.***>) escribió:

update: I can now get the plugin connected if I do the following: (all running as administrator) after reboot or initial PC start: manually run the plugin.exe then touchportal than msfs So I confirm that it will connect after a manual run.

however if I then close touch portal and msfs and later try this again, the plugin wont connect unless I reboot the PC.. Not very practical but this is all I can do on this. No idea how to fix this but the guys from Touch Portal have confirmed that plugins need to be modified. No idea how. The VLC plugin also was modified.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub

https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-804378218, or unsubscribe

https://github.com/notifications/unsubscribe-auth/AACVFH5PEG53O6GEDCAKB2LTE6THJANCNFSM4ZQIT7KA .

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-804450049

p4cm4n commented 3 years ago

yes, but that may (or may not) help debugging the problem, at least will help if somebody who is in the same place as us :)

El mar, 23 mar 2021 a las 0:09, cusance @.***>) escribió:

yes same here. I know I can close it like that but it would be nice if someone could adjust whatever is needed, to make this run correctly. i don't see that it will run correctly for anyone on the new version of TP. Its beyond my abilities I fear.

On 22 Mar 2021, 22:58, at 22:58, p4c m4n @.***> wrote:

The plugin appears in the details page of task manager, you can close it from there without the need to reboot, also i managed to run it without administrator account, maybe because i am admin in my system? IDK

El lun, 22 mar 2021 a las 21:39, cusance @.***>) escribió:

update: I can now get the plugin connected if I do the following: (all running as administrator) after reboot or initial PC start: manually run the plugin.exe then touchportal than msfs So I confirm that it will connect after a manual run.

however if I then close touch portal and msfs and later try this again, the plugin wont connect unless I reboot the PC.. Not very practical but this is all I can do on this. No idea how to fix this but the guys from Touch Portal have confirmed that plugins need to be modified. No idea how. The VLC plugin also was modified.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub

< https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-804378218 , or unsubscribe

< https://github.com/notifications/unsubscribe-auth/AACVFH5PEG53O6GEDCAKB2LTE6THJANCNFSM4ZQIT7KA

.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub:

https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-804450049

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-804454488, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVFH2IAUNSYJS7LTEYYJLTE7EZJANCNFSM4ZQIT7KA .

tlewis17 commented 3 years ago

The exe that runs will auto reconnect to MSFS without having to restart. That is handled without anything to do with Touch Portal. However, there is code specifically in there that when Touch Portal tells the program to close, it should close. Maybe something to do with that. I'll check out that specific part because I could see that causing an issue based on the situation you described.

cusance commented 3 years ago

thanks to be clear, the plugin does not connect with MSFS on opening TP. It now needs to be started manually. Once active it WILL disconnect when MSFS closes, obviously,  and will reconnect again when MSFS is restarted as long as TP wasn't shut down. (I do note that VLC had a similar issue but that threw a script error message after the update of TP  and was fixed quickly.) But even when started manually and functioning well, once TP has been closed and then reopened, the plugin doesnt connect, and cant be restarted manually either unless PC is rebooted or the plugin is closed via taskmaster first. Clever stuff if you understand all this, its mystifying to me  😣

On 22 Mar 2021, 23:50, at 23:50, Tim @.***> wrote:

The exe that runs will auto reconnect to MSFS without having to restart. That is handled without anything to do with Touch Portal. However, there is code specifically in there that when Touch Portal tells the program to close, it should close. Maybe something to do with that. I'll check out that specific part because I could see that causing an issue based on the situation you described.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-804473666

tlewis17 commented 3 years ago

Interesting. But yes, it only attempts connecting to TP once and that is once the Plugin starts. I think the auto start might be broken. I'll look into it in a day or two, busy studying for an exam for Tuesday.

cusance commented 3 years ago

well thats a lot more important than the plugin. Good luck.

On 23 Mar 2021, 04:05, at 04:05, Tim @.***> wrote:

Interesting. But yes, it only attempts connecting to TP once and that is once the Plugin starts. I think the auto start might be broken. I'll look into it in a day or two, busy studying for an exam for Tuesday.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-804600171

p4cm4n commented 3 years ago

First things first, hope you’re lucky with your exam bro :)

El El mar, 23 mar 2021 a las 10:55, cusance @.***> escribió:

well thats a lot more important than the plugin. Good luck.

On 23 Mar 2021, 04:05, at 04:05, Tim @.***> wrote:

Interesting. But yes, it only attempts connecting to TP once and that is once the Plugin starts. I think the auto start might be broken. I'll look into it in a day or two, busy studying for an exam for Tuesday.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub:

https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-804600171

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-804769271, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVFH2P6R56ZWZAAHIAJT3TFBQR5ANCNFSM4ZQIT7KA .

cusance commented 3 years ago

UPDATE: I am not sure you need to do anything with the plugin. At least for me since the TP V2.3.006 the plugin connects correctly as it should by starting the TP. No need anymore for manual start. So whatever happened with the TP updates (there were a few in rapid succession) seems to have fixed the connection issues of the MSFS plugin.

tlewis17 commented 3 years ago

Update: I think I found the cause. TP no longer sends "ClosePlugin" commands if you exit from the tray icon. Maybe other places too. So that leaves the plugin running. Also, what that means is that when it starts up again it launches another instance of the plugin which terminates itself as there is code in place to ensure only one instance is running.

Further, if it is still running and TP isn't, it has lost the connection to TP. It only ever attempts to connect to TP on startup.

So I have 2 fixes that I'm working on for the 0.5.3 release coming up.

  1. If TP connection fails, exit plugin.
  2. On startup, if unable to connect to TP, exit.

This will tie the lifecycle of the plugin to TP at all times. Meaning, you shouldn't ever have a scenario where the Plugin is running without TP already running. Also note, the start/stop from TP's plugin settings should properly close and restart the plugin.

cusance commented 3 years ago

great job, it sounds to me that you have found the perfect solution. thanks.

On 6 Apr 2021, 07:42, at 07:42, Tim @.***> wrote:

Update: I think I found the cause. TP no longer sends "ClosePlugin" commands if you exit from the tray icon. Maybe other places too. So that leaves the plugin running. Also, what that means is that when it starts up again it launches another instance of the plugin which terminates itself as there is code in place to ensure only one instance is running.

Further, if it is still running and TP isn't, it has lost the connection to TP. It only ever attempts to connect to TP on startup.

So I have 2 fixes that I'm working on for the 0.5.3 release coming up.

  1. If TP connection fails, exit plugin.
  2. On startup, if unable to connect to TP, exit.

This will tie the lifecycle of the plugin to TP at all times. Meaning, you shouldn't ever have a scenario where the Plugin is running without TP already running. Also note, the start/stop from TP's plugin settings should properly close and restart the plugin.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#issuecomment-813867085

p4cm4n commented 3 years ago

yeaaah! :D

El mar, 13 abr 2021 a las 8:22, Tim @.***>) escribió:

Closed #30 https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Touch-Portal-MSFS/MSFSTouchPortalPlugin/issues/30#event-4586025831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVFH5ENZCKONZ44V5RPQLTIPPIVANCNFSM4ZQIT7KA .

Richardljacks commented 2 years ago

I use TP with every flight but sometimes the plugin just stops working. The only way to reconnect is to exit flightsim and then restart. The plugin works again right after the fsuipc flashes up on the screen. Any suggestions?? Thanks!!

cusance commented 2 years ago

I don't seem to have that issue. But then I don't use fsuipc which I suspect is the problem. I use TP via WIFI and SpadNext with Simconnect.All I can suggest, assuming fsuipc is the interfering problem is that you ensure you have the latest version. Also register this issue with TP support. They may be able to assist. -------- Original message --------From: Richardljacks @.> Date: 23/10/2021 14:50 (GMT+00:00) To: tlewis17/MSFSTouchPortalPlugin @.> Cc: cusance @.>, Mention @.> Subject: Re: [tlewis17/MSFSTouchPortalPlugin] New update breaks plugin connection (#30) I use TP with every flight but sometimes the plugin just stops working. The only way to reconnect is to exit flightsim and then restart. The plugin works again right after the fsuipc flashes up on the screen. Any suggestions?? Thanks!!

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

Richardljacks commented 2 years ago

Thanks very much for your informative reply. I have downloaded SpadNext to try that route. My TP Screen also uses wifi and is a Samsung tab.Question for you, do you also have fsuipc running? My virtual airline acars requires fsuipc to run but I don't want it to be a conflict. I have never used spadnext before, so I want to make sure it is used for connecting vs fsuipc. Thanks again,Richard 

Sent from Yahoo Mail on Android

On Sat, Oct 23, 2021 at 9:59 AM, @.***> wrote:

I don't seem to have that issue. But then I don't use fsuipc which I suspect is the problem. I use TP via WIFI and SpadNext with Simconnect.All I can suggest, assuming fsuipc is the interfering problem is that you ensure you have the latest version. Also register this issue with TP support. They may be able to assist. -------- Original message --------From: Richardljacks @.> Date: 23/10/2021 14:50 (GMT+00:00) To: tlewis17/MSFSTouchPortalPlugin @.> Cc: cusance @.>, Mention @.> Subject: Re: [tlewis17/MSFSTouchPortalPlugin] New update breaks plugin connection (#30) I use TP with every flight but sometimes the plugin just stops working. The only way to reconnect is to exit flightsim and then restart. The plugin works again right after the fsuipc flashes up on the screen. Any suggestions?? Thanks!!

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

cusance commented 2 years ago

Just to clarify, I use SpadNext to control 5 saitek instrument panels, saitek yoke, saitek radio and switch panel.I have created my own touch portal pages to control other aspects of the SimWith an old Apple iPad, not much good for anything else. All drivers and versions are up to date. I run everything as administrator as I am the only user on this computer.The image attached is self explanatory I hope. -------- Original message --------From: Richardljacks @.> Date: 24/10/2021 13:26 (GMT+00:00) To: tlewis17/MSFSTouchPortalPlugin @.> Cc: cusance @.>, Mention @.> Subject: Re: [tlewis17/MSFSTouchPortalPlugin] New update breaks plugin connection (#30)

Thanks very much for your informative reply. I have downloaded SpadNext to try that route. My TP Screen also uses wifi and is a Samsung tab.Question for you, do you also have fsuipc running? My virtual airline acars requires fsuipc to run but I don't want it to be a conflict. I have never used spadnext before, so I want to make sure it is used for connecting vs fsuipc.

Thanks again,Richard 

Sent from Yahoo Mail on Android

On Sat, Oct 23, 2021 at 9:59 AM, @.***> wrote:

I don't seem to have that issue. But then I don't use fsuipc which I suspect is the problem. I use TP via WIFI and SpadNext with Simconnect.All I can suggest, assuming fsuipc is the interfering problem is that you ensure you have the latest version. Also register this issue with TP support. They may be able to assist.

-------- Original message --------From: Richardljacks @.> Date: 23/10/2021 14:50 (GMT+00:00) To: tlewis17/MSFSTouchPortalPlugin @.> Cc: cusance @.>, Mention @.> Subject: Re: [tlewis17/MSFSTouchPortalPlugin] New update breaks plugin connection (#30)

I use TP with every flight but sometimes the plugin just stops working. The only way to reconnect is to exit flightsim and then restart. The plugin works again right after the fsuipc flashes up on the screen. Any suggestions?? Thanks!!

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

cusance commented 2 years ago

I am very happy to assist with touch portal and SpadNext but have never got to grips with fsuipc. I fear I don't understand it. It seems extremely complicated to me.My setup below -------- Original message --------From: Richardljacks @.> Date: 24/10/2021 13:26 (GMT+00:00) To: tlewis17/MSFSTouchPortalPlugin @.> Cc: cusance @.>, Mention @.> Subject: Re: [tlewis17/MSFSTouchPortalPlugin] New update breaks plugin connection (#30)

Thanks very much for your informative reply. I have downloaded SpadNext to try that route. My TP Screen also uses wifi and is a Samsung tab.Question for you, do you also have fsuipc running? My virtual airline acars requires fsuipc to run but I don't want it to be a conflict. I have never used spadnext before, so I want to make sure it is used for connecting vs fsuipc.

Thanks again,Richard 

Sent from Yahoo Mail on Android

On Sat, Oct 23, 2021 at 9:59 AM, @.***> wrote:

I don't seem to have that issue. But then I don't use fsuipc which I suspect is the problem. I use TP via WIFI and SpadNext with Simconnect.All I can suggest, assuming fsuipc is the interfering problem is that you ensure you have the latest version. Also register this issue with TP support. They may be able to assist.

-------- Original message --------From: Richardljacks @.> Date: 23/10/2021 14:50 (GMT+00:00) To: tlewis17/MSFSTouchPortalPlugin @.> Cc: cusance @.>, Mention @.> Subject: Re: [tlewis17/MSFSTouchPortalPlugin] New update breaks plugin connection (#30)

I use TP with every flight but sometimes the plugin just stops working. The only way to reconnect is to exit flightsim and then restart. The plugin works again right after the fsuipc flashes up on the screen. Any suggestions?? Thanks!!

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.