tleyden / open-ocr

Run your own OCR-as-a-Service using Tesseract and Docker
Apache License 2.0
1.33k stars 223 forks source link

Make DNS entries into lists #59

Closed lucaswiman closed 8 years ago

lucaswiman commented 8 years ago

@tleyden This pull request fixes an issue I ran into while testing out open-ocr on OS X. Here's my environment:

$ docker -v
Docker version 1.9.1, build a34a1d5
$ docker-machine -version
docker-machine version 0.5.1 (HEAD)
$ docker-compose -v
docker-compose version 1.5.2, build unknown

On HEAD, I get the following error:

~/opensource/open-ocr/docker-compose $ docker-compose up -d
Recreating dockercompose_rabbitmq_1
ERROR: json: cannot unmarshal string into Go value of type []string

The fix is as suggested in https://github.com/docker/compose/issues/2515#issuecomment-163214982. After updating the DNS entries in docker-compose.yml to be lists, I get the following output, and the service seems to work:

~/opensource/open-ocr/docker-compose $ docker-compose up -d
Starting 9f539a3813_dockercompose_rabbitmq_1
Starting dockercompose_openocr_1
Starting dockercompose_strokewidthtransform_1
Starting dockercompose_openocrworker_1

Thanks for putting all your work into open-ocr! Other than this minor issue with the docker setup, it seems to work perfectly for my use case!

tleyden commented 8 years ago

Thanks for your contribution!

lucaswiman commented 8 years ago

Thanks!