Improved docker-compose.yml and own Dockerfile - Githubissues

tleyden / open-ocr

Run your own OCR-as-a-Service using Tesseract and Docker

Apache License 2.0

1.33k stars 223 forks source link

Improved docker-compose.yml and own Dockerfile #85

Open minyk opened 7 years ago

minyk commented 7 years ago

Hi @tleyden First of all, this is what I need! Thank you!

After some hours with docker-compose up and down, I think I improve some part of the docker-compose.yml. See my branch: https://github.com/minyk/open-ocr/tree/feature/docker-compose/docker-compose and major changes are here:

Add own `open-ocr/Dockerfile` and `open-ocr-preprossor/Dockerfile` for local build.

Update container OS to Ubuntu 16.04 LTS.
Using mirror://mirror.ubuntu.com for apt.
Layer build command of Dockerfile carefully for reusability.
Comment out unnecessary languages from open-ocr/Dockerfile ’s language section(all languages are enabled by default).
open-ocr-preprocessor is based on open-ocr image. Save some disk space.

Modify `docker-compose.yml`.

Remove tcp port mapping of rabbitmq service: depends_on or link is enough for.
Add healthcheck for rabbitmq service. No more connection refused error.
Reorder container startup. This is needed to build open-ocr:build image before open-ocr-preprossor:build.
All scripts directories are mounted with read only mode.

How about these changes? If you may accept, I will send PR for these.

Thank you again for great works!

tleyden commented 7 years ago

These sound like good changes! Can you rebase your branch on the current master and send a PR? Somehow your branch was based on an older version of master (14 commits behind)