Feature: Settings - Githubissues

tlf30 / monkey-netty

A implementation of a server-client communication system for jMonkeyEngine using Netty.IO that utilizes both TCP and UDP communication.

MIT License

12 stars 5 forks source link

Feature: Settings #12

Open oxplay2 opened 3 years ago

oxplay2 commented 3 years ago

As discussed, we need to desgin a way to pass Monkey-Netty Settings.

There are multiple ways like:

Use JME AppSettings Disadvantage with this solution is that someone would not know that he can configure it there, unless he will read Monkey-Netty wiki.
use Java Properties Its String->String, instead String->Object so IMO bad solution for this one.
use own HashMap Settings class utility Disadvantage that we need additional class instead of using ready2use solutions.

Im not sure what would be your decision, but for me options 1 and 3 are fine. If you have more options for Settings, please tell

tlf30 commented 3 years ago

We could use apache configurations 2, I have used it on other projects and it works good. We could have a network.properties file.

oxplay2 commented 3 years ago

as a global settings, sounds good.

But what about "per Server/Client" settings?

For example some Client might want have high timeout value, while other low value. Same about servers, since each might want different settings.

Do apache configurations 2 will allow this for Monkey-Netty?

tlf30 commented 3 years ago

Hmm, apache configuration 2 would be fine for global settings, but not on a per server/client basis.

tlf30 commented 3 years ago

@oxplay2 I have created an initial implementation for settings. I am still playing with it. I will probably make it a hashmap wrapper before I am done, but right now I am playing with how the architecture needs to change to accommodate this.

See #35 for my initial implementation. It does have some large changes to the architecture, which I have been wanting to do for some times anyways. But to implement these changes they were required. I will probably cut a v1.0.0 release for this, along with a couple other features I want to implement that will be breaking changes.

EDIT: The other big feature I want in v1.0.0 is #15. And I think this changes will make that easier to implement.

oxplay2 commented 3 years ago

thanks for notification :)

sounds good, no rush, this should be done very well, so take time to make it clever way. Settings can wait until you finish other things too.